From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 327671922EF; Wed, 6 Nov 2024 13:07:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730898477; cv=none; b=Q3Zwlwg0gXyitcK6B+fTZUJd9LafyDaSUfS2qlEaXZYyrfgYNP8iqDXt2J+yDxaJTNPMt+S0B1VR6ybIOww5GwK3I8MYUKdvQ11N2FcTLVjGNEq5kbZcklg1XliVSQsBzkDmsJmvAw9Tck6SF8/MHKNKsn2DW/21jZ2P9dMRtsc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730898477; c=relaxed/simple; bh=9WmKZuaN885RgGF5U+qEjdRktaP+H+DfA3qYNq/WVaw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XLlVMSx8fPqPNCdMGE6qKGdkwpKnkTUFtBgUk7E5QPveDXgzaDz/KavZmEmlA+nuJM29KR7o7q9S9A/X84OZHQ2/GhKovnyvt+ZoCPI1PohPK3T9E7Kcfx3oTL4zMIzKLUS6tJTe2/uGduQZbexNQrwXZYe/oA1UnSHPkz3TPa0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=0X+5OCkh; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="0X+5OCkh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AB375C4CECD; Wed, 6 Nov 2024 13:07:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1730898477; bh=9WmKZuaN885RgGF5U+qEjdRktaP+H+DfA3qYNq/WVaw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=0X+5OCkhZq9/GY39Mv1m6DoAZUKTHjKZmsO3tiJiqCXoAEZpRwWUUw4L6J7MUSnIt SZx+UA+W8CkdDIqAsB2I8VEPkUebXBfS3dpma63ua8z5rvB6oMbVndLpGVi5iqx3LR 2rGN0u9ac4F9lT1IeoaMWCx/0T8lqe4lVvbExKWo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, "Luis Henriques (SUSE)" , Jan Kara , Theodore Tso , stable@kernel.org Subject: [PATCH 5.4 251/462] ext4: fix incorrect tid assumption in ext4_wait_for_tail_page_commit() Date: Wed, 6 Nov 2024 13:02:24 +0100 Message-ID: <20241106120337.723672382@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241106120331.497003148@linuxfoundation.org> References: <20241106120331.497003148@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Luis Henriques (SUSE) commit dd589b0f1445e1ea1085b98edca6e4d5dedb98d0 upstream. Function ext4_wait_for_tail_page_commit() assumes that '0' is not a valid value for transaction IDs, which is incorrect. Don't assume that and invoke jbd2_log_wait_commit() if the journal had a committing transaction instead. Signed-off-by: Luis Henriques (SUSE) Reviewed-by: Jan Kara Link: https://patch.msgid.link/20240724161119.13448-2-luis.henriques@linux.dev Signed-off-by: Theodore Ts'o Cc: stable@kernel.org Signed-off-by: Greg Kroah-Hartman --- fs/ext4/inode.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -5575,8 +5575,9 @@ static void ext4_wait_for_tail_page_comm struct page *page; unsigned offset; journal_t *journal = EXT4_SB(inode->i_sb)->s_journal; - tid_t commit_tid = 0; + tid_t commit_tid; int ret; + bool has_transaction; offset = inode->i_size & (PAGE_SIZE - 1); /* @@ -5601,12 +5602,14 @@ static void ext4_wait_for_tail_page_comm put_page(page); if (ret != -EBUSY) return; - commit_tid = 0; + has_transaction = false; read_lock(&journal->j_state_lock); - if (journal->j_committing_transaction) + if (journal->j_committing_transaction) { commit_tid = journal->j_committing_transaction->t_tid; + has_transaction = true; + } read_unlock(&journal->j_state_lock); - if (commit_tid) + if (has_transaction) jbd2_log_wait_commit(journal, commit_tid); } }