From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76C5C1E0488; Wed, 6 Nov 2024 13:08:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730898518; cv=none; b=SK+Mhx2uMu0OZ1/yNWUVTWb0mVwpTb2fDRbTk7dJaDxqQROQ2tA28cIPHFXpABy+1mMSqiaPwM+zstcXG2VUgO0eGjAfU8Ug7aLstk221gK4yH3GB+XmJYBPqlDUEECnsemf75TgQFdIbIm1yW5/xPxRcIXjEGYxA5ZQHaqtZj0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730898518; c=relaxed/simple; bh=2relAeieY2ejuwkNX8GDJpD3eGVL3gjrok8+pR0FFUI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tR/VsFWsV/H3u36li56VrKA/Aci0JuGgdnATnc3JXj/7lNNvDKSXoSZ+xk25MsPN+92Gw1pjQEyy3FWggnOojnH/IHylOGHvxrZNTB8EMhdkfyratkKMHm/BDvQrx7B7HGSOkQ0qoze3SrDe11FRqjyWE+5f7pYA0d9Gl+GZSQk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=OvHuz/3o; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="OvHuz/3o" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EE89FC4CED3; Wed, 6 Nov 2024 13:08:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1730898518; bh=2relAeieY2ejuwkNX8GDJpD3eGVL3gjrok8+pR0FFUI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OvHuz/3omwboe76uWsolWbgZX2G7vtsKgcHO5nvKfBbAfKqvNirzKSw3oUeS1dEbf LrntIe7HsS04b3VQpCInLUsd/hf8VeDZbiWlDGCS3/sWhclBVo3C7kxzD2HyplvBw5 l6Q2Aw1ZOuKy6n9bgCuGiejTeHLyG9XjMr9GxoEI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Lizhi Xu , Joseph Qi , Heming Zhao , Changwei Ge , Gang He , Joel Becker , Jun Piao , Junxiao Bi , Mark Fasheh , Andrew Morton Subject: [PATCH 5.4 264/462] ocfs2: fix possible null-ptr-deref in ocfs2_set_buffer_uptodate Date: Wed, 6 Nov 2024 13:02:37 +0100 Message-ID: <20241106120338.050312184@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241106120331.497003148@linuxfoundation.org> References: <20241106120331.497003148@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Lizhi Xu commit 33b525cef4cff49e216e4133cc48452e11c0391e upstream. When doing cleanup, if flags without OCFS2_BH_READAHEAD, it may trigger NULL pointer dereference in the following ocfs2_set_buffer_uptodate() if bh is NULL. Link: https://lkml.kernel.org/r/20240902023636.1843422-3-joseph.qi@linux.alibaba.com Fixes: cf76c78595ca ("ocfs2: don't put and assigning null to bh allocated outside") Signed-off-by: Lizhi Xu Signed-off-by: Joseph Qi Reviewed-by: Joseph Qi Reported-by: Heming Zhao Suggested-by: Heming Zhao Cc: [4.20+] Cc: Changwei Ge Cc: Gang He Cc: Joel Becker Cc: Jun Piao Cc: Junxiao Bi Cc: Mark Fasheh Signed-off-by: Andrew Morton Signed-off-by: Greg Kroah-Hartman --- fs/ocfs2/buffer_head_io.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/fs/ocfs2/buffer_head_io.c +++ b/fs/ocfs2/buffer_head_io.c @@ -390,7 +390,8 @@ read_failure: /* Always set the buffer in the cache, even if it was * a forced read, or read-ahead which hasn't yet * completed. */ - ocfs2_set_buffer_uptodate(ci, bh); + if (bh) + ocfs2_set_buffer_uptodate(ci, bh); } ocfs2_metadata_cache_io_unlock(ci);