From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BA0B1F12F9; Wed, 6 Nov 2024 13:09:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730898579; cv=none; b=Qh79fxZVAeWUNIwCUn8FtSImmsazNZierNJV2eZHbOCVDYdRhABBnZPyvKGdEcdlQyUbEsqI9PbSIPNlWVfUdXpAk+NJB/fRWGDjan4Uf4rPeLg2K9chXvzO2Hjr6EtyVSUqlfGjn0tcR6Y7+MLG6gQcZmexq/Y+gAOCh/o2OZc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730898579; c=relaxed/simple; bh=nHhMh90b3gIc+BeDZ5c/yRNLnZ1M9KK8hyUGVY/BqNY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ug0E2lqUwgIRu+EppdUqj0TUj8w9kRhsFqBXqDL5df3Go4wWXuAIQadenkq4EhTRkvCBSLAfZcp6YYiKBk6TNlEKEp0CpLQOqgn7fjjcu2FuZLaSzUpAMbbsPcXfT/B9GoXs8oBSfZjJqrD84ci+1/OQNYj2B/dYLMwXOg2TrVA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=P7CLG5bl; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="P7CLG5bl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D84C1C4CECD; Wed, 6 Nov 2024 13:09:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1730898579; bh=nHhMh90b3gIc+BeDZ5c/yRNLnZ1M9KK8hyUGVY/BqNY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=P7CLG5bl+ukWBmVkP8JvCS2bh4fw0sEkaAmiKauPBOsoO/r0qoiDKpLltIKlx6op7 VZFzfhhuD0/FpynEM9mjHwUdWw85lrlkWgsfzygx2eY8PEhsmoiSLUHnhqP99n6G+C Ra9oDFwxC+lRIW/jsegJXlGOVfQr8PbNck2/MF4E= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Laurent Pinchart , Chen-Yu Tsai , Tomi Valkeinen , Sakari Ailus Subject: [PATCH 5.4 268/462] media: sun4i_csi: Implement link validate for sun4i_csi subdev Date: Wed, 6 Nov 2024 13:02:41 +0100 Message-ID: <20241106120338.147674498@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241106120331.497003148@linuxfoundation.org> References: <20241106120331.497003148@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Laurent Pinchart commit 2dc5d5d401f5c6cecd97800ffef82e8d17d228f0 upstream. The sun4i_csi driver doesn't implement link validation for the subdev it registers, leaving the link between the subdev and its source unvalidated. Fix it, using the v4l2_subdev_link_validate() helper. Fixes: 577bbf23b758 ("media: sunxi: Add A10 CSI driver") Cc: stable@vger.kernel.org Signed-off-by: Laurent Pinchart Acked-by: Chen-Yu Tsai Reviewed-by: Tomi Valkeinen Acked-by: Sakari Ailus Signed-off-by: Greg Kroah-Hartman --- drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.c | 5 +++++ 1 file changed, 5 insertions(+) --- a/drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.c +++ b/drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.c @@ -33,6 +33,10 @@ static const struct media_entity_operati .link_validate = v4l2_subdev_link_validate, }; +static const struct media_entity_operations sun4i_csi_subdev_entity_ops = { + .link_validate = v4l2_subdev_link_validate, +}; + static int sun4i_csi_notify_bound(struct v4l2_async_notifier *notifier, struct v4l2_subdev *subdev, struct v4l2_async_subdev *asd) @@ -221,6 +225,7 @@ static int sun4i_csi_probe(struct platfo v4l2_subdev_init(subdev, &sun4i_csi_subdev_ops); subdev->flags = V4L2_SUBDEV_FL_HAS_DEVNODE | V4L2_SUBDEV_FL_HAS_EVENTS; subdev->entity.function = MEDIA_ENT_F_VID_IF_BRIDGE; + subdev->entity.ops = &sun4i_csi_subdev_entity_ops; subdev->owner = THIS_MODULE; snprintf(subdev->name, sizeof(subdev->name), "sun4i-csi-0"); v4l2_set_subdevdata(subdev, csi);