From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50E5F1EF081; Wed, 6 Nov 2024 13:09:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730898567; cv=none; b=Pk/GUoLFr+2xnyzqZl/UDYF9UxakLOU17z2GR846YfNj7AJ44/avlicd30v7iPx6IqEvcFzmiUAlOKr94uNvWQflb0a8jsGhI7NODDj314wTUptF+P88zGRfasIRiFSrScksex4Ez7G1HbQoGReFgnGDrujYjMCSKMDuDGQXdB0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730898567; c=relaxed/simple; bh=5ron9kDxJThxicfsfBsMwJ+ST1pf3zljG4RlD1D9c5U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rgYaNPqOe1qoDzeeo6XDPuF3ajtxzVSAQbid+/CB0ovfO+sC5LEiLOUof5HhH8pZb6NUMDa1bENqDAtfyvtnSrtpm8N/UvD7q58TZzVCZIi/+BgnXrUAmYuf+xM+kfw1q4/oQ+UyeqLU/8FD+QHUUWESMx7+D4mnH3O7PwtyCW8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=sxdlmz1B; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="sxdlmz1B" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CDECBC4CED3; Wed, 6 Nov 2024 13:09:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1730898567; bh=5ron9kDxJThxicfsfBsMwJ+ST1pf3zljG4RlD1D9c5U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sxdlmz1BnAltBc9a9yxL5rqOhgUtfIsjw1LGvTBPpmCsT/VIGexjoWs1j6dhLFEcR c62tvwQgOVYN47FpUEdah7Dvj7/gmpDCZmI3SiUWn6L4QpwqS6jnC7K1HV9RFk1K6u CGWmeQ/++AljILO56dH1b0lqIju2DC9Bru+hUVD8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jinjie Ruan , Mukesh Kumar Savaliya , Vladimir Zapolskiy , Andi Shyti , Sasha Levin Subject: [PATCH 5.4 282/462] i2c: qcom-geni: Use IRQF_NO_AUTOEN flag in request_irq() Date: Wed, 6 Nov 2024 13:02:55 +0100 Message-ID: <20241106120338.489689858@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241106120331.497003148@linuxfoundation.org> References: <20241106120331.497003148@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jinjie Ruan [ Upstream commit e2c85d85a05f16af2223fcc0195ff50a7938b372 ] disable_irq() after request_irq() still has a time gap in which interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will disable IRQ auto-enable when request IRQ. Fixes: 37692de5d523 ("i2c: i2c-qcom-geni: Add bus driver for the Qualcomm GENI I2C controller") Signed-off-by: Jinjie Ruan Cc: # v4.19+ Acked-by: Mukesh Kumar Savaliya Reviewed-by: Vladimir Zapolskiy Signed-off-by: Andi Shyti Signed-off-by: Sasha Levin --- drivers/i2c/busses/i2c-qcom-geni.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c index e16c38fb37900..20fe16b1d4c83 100644 --- a/drivers/i2c/busses/i2c-qcom-geni.c +++ b/drivers/i2c/busses/i2c-qcom-geni.c @@ -571,15 +571,13 @@ static int geni_i2c_probe(struct platform_device *pdev) init_completion(&gi2c->done); spin_lock_init(&gi2c->lock); platform_set_drvdata(pdev, gi2c); - ret = devm_request_irq(dev, gi2c->irq, geni_i2c_irq, 0, + ret = devm_request_irq(dev, gi2c->irq, geni_i2c_irq, IRQF_NO_AUTOEN, dev_name(dev), gi2c); if (ret) { dev_err(dev, "Request_irq failed:%d: err:%d\n", gi2c->irq, ret); return ret; } - /* Disable the interrupt so that the system can enter low-power mode */ - disable_irq(gi2c->irq); i2c_set_adapdata(&gi2c->adap, gi2c); gi2c->adap.dev.parent = dev; gi2c->adap.dev.of_node = dev->of_node; -- 2.43.0