From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBEDB1F4FD4; Wed, 6 Nov 2024 13:10:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730898660; cv=none; b=BQWFEGJ1rDU9WVBUg8l0pH4uvvhZ4UvEE+8aUeerHWCpyjgurIz6tbIm+AmGziyzQhf+kkKuVlKlK0KX9y5Q4qs75vkgMwpzvrF7v0HYB+Y0eE/oMzg4cYPlvqHRSyEZyFEML+F/yuyG+xFtpgyBcOXwhzhpvGeo01ExSNSPzaU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730898660; c=relaxed/simple; bh=BVh7qXWxt4mPeMygMb8mIWr72ZYO1BIf44ySBJtWvzo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IpaaYwXsHYbWHNKzUECGHefH5KM3Tz3GULWFtkcf1q2Q1cgK2+Gm9b/WlbTHHSjo3uiQ9POB12BfdnVoapXH2lyqVWNnNESHDi/2i3gVMvlgtRi+TtFE3AICFa85geHFknbAWqzjcIKSPotRBTgTE5jRXL60+93NxWzCc/MUhQs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=D2iCKA6j; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="D2iCKA6j" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7632DC4CECD; Wed, 6 Nov 2024 13:10:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1730898659; bh=BVh7qXWxt4mPeMygMb8mIWr72ZYO1BIf44ySBJtWvzo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=D2iCKA6j7GDtcS79vFW1L4ACrc2PYb2I0xYoxe7r7Jo5Z8XrS3TdDY1y5+EGAcmwP gpZSJyyDl8sDGyxr6At90ibcKPTdQGVvGYJLZZEmLGs8CgIB4pZbwqjQrfYutFrE4E wSzqpRDRJxX0Ms5iq++Kx6UAWPwGpFYZUmzQS05c= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Gerald Schaefer , Heiko Carstens , Sasha Levin Subject: [PATCH 5.4 305/462] s390/mm: Add cond_resched() to cmm_alloc/free_pages() Date: Wed, 6 Nov 2024 13:03:18 +0100 Message-ID: <20241106120339.061075314@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241106120331.497003148@linuxfoundation.org> References: <20241106120331.497003148@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Gerald Schaefer [ Upstream commit 131b8db78558120f58c5dc745ea9655f6b854162 ] Adding/removing large amount of pages at once to/from the CMM balloon can result in rcu_sched stalls or workqueue lockups, because of busy looping w/o cond_resched(). Prevent this by adding a cond_resched(). cmm_free_pages() holds a spin_lock while looping, so it cannot be added directly to the existing loop. Instead, introduce a wrapper function that operates on maximum 256 pages at once, and add it there. Signed-off-by: Gerald Schaefer Reviewed-by: Heiko Carstens Signed-off-by: Heiko Carstens Signed-off-by: Sasha Levin --- arch/s390/mm/cmm.c | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/arch/s390/mm/cmm.c b/arch/s390/mm/cmm.c index a51c892f14f3e..756aefbd05249 100644 --- a/arch/s390/mm/cmm.c +++ b/arch/s390/mm/cmm.c @@ -98,11 +98,12 @@ static long cmm_alloc_pages(long nr, long *counter, (*counter)++; spin_unlock(&cmm_lock); nr--; + cond_resched(); } return nr; } -static long cmm_free_pages(long nr, long *counter, struct cmm_page_array **list) +static long __cmm_free_pages(long nr, long *counter, struct cmm_page_array **list) { struct cmm_page_array *pa; unsigned long addr; @@ -126,6 +127,21 @@ static long cmm_free_pages(long nr, long *counter, struct cmm_page_array **list) return nr; } +static long cmm_free_pages(long nr, long *counter, struct cmm_page_array **list) +{ + long inc = 0; + + while (nr) { + inc = min(256L, nr); + nr -= inc; + inc = __cmm_free_pages(inc, counter, list); + if (inc) + break; + cond_resched(); + } + return nr + inc; +} + static int cmm_oom_notify(struct notifier_block *self, unsigned long dummy, void *parm) { -- 2.43.0