From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F2D81DE4CA; Wed, 6 Nov 2024 13:12:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730898725; cv=none; b=NnwkaUjeFaFOQrxR3cmgqNtykn2czCuNsydXu3mAmTSFmdUxqiPCxxPzGqDpVLMGunWZrNE31s8rqkbkJnQCSVIjgWle/JyJhRypQS2GivSFboYADuSnlwz8QJgutUKqxdTVg7Vofn9D4eiRVwsU9i/3dMzCuAbiIR4Q/z9pSgk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730898725; c=relaxed/simple; bh=ZV3NnxtglXdeWiok8R9ZSMRZfz5ihfewUFY1NFHYmno=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tMLJM4kV87d0wntNlsini5MwFzBDWY0/TnsjEXyAyxG6w3b5L/Os+qEpot6jBkdIGGSG61nkQdK+N0QW1+ZOk+OJKpOSr5MJlh/O3usB2/yQPfb/Hv8U90I1f6VmmdzYpGlROittjWVWp47ItYReE4DoGdvJ7eTJu457W+vb2S0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=MP/djLl9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="MP/djLl9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B179CC4CECD; Wed, 6 Nov 2024 13:12:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1730898725; bh=ZV3NnxtglXdeWiok8R9ZSMRZfz5ihfewUFY1NFHYmno=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MP/djLl9XKLKPLakRgQK42HVFijWsq0JlKpdQ/jHnqoR6mi4yA1ZCy47rwzdRbSza Wro91dgzpU7Rhvu9Unpt/gK9saIQUE7GjRraqncP+o4H/qKdQApHnjAH34T/rLFT1A 2gI//Cl1b3PfyPhCQChxr/RsHFvheDY8yb6K8yPc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Thomas Richter , Sumanth Korikkar , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Sasha Levin Subject: [PATCH 5.4 307/462] s390/cpum_sf: Remove WARN_ON_ONCE statements Date: Wed, 6 Nov 2024 13:03:20 +0100 Message-ID: <20241106120339.111127212@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241106120331.497003148@linuxfoundation.org> References: <20241106120331.497003148@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Thomas Richter [ Upstream commit b495e710157606889f2d8bdc62aebf2aa02f67a7 ] Remove WARN_ON_ONCE statements. These have not triggered in the past. Signed-off-by: Thomas Richter Acked-by: Sumanth Korikkar Cc: Heiko Carstens Cc: Vasily Gorbik Cc: Alexander Gordeev Signed-off-by: Vasily Gorbik Signed-off-by: Sasha Levin --- arch/s390/kernel/perf_cpum_sf.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/arch/s390/kernel/perf_cpum_sf.c b/arch/s390/kernel/perf_cpum_sf.c index b83bddf35e068..4f251cd624d7e 100644 --- a/arch/s390/kernel/perf_cpum_sf.c +++ b/arch/s390/kernel/perf_cpum_sf.c @@ -1412,7 +1412,7 @@ static int aux_output_begin(struct perf_output_handle *handle, unsigned long head, base, offset; struct hws_trailer_entry *te; - if (WARN_ON_ONCE(handle->head & ~PAGE_MASK)) + if (handle->head & ~PAGE_MASK) return -EINVAL; aux->head = handle->head >> PAGE_SHIFT; @@ -1580,7 +1580,7 @@ static void hw_collect_aux(struct cpu_hw_sf *cpuhw) unsigned long num_sdb; aux = perf_get_aux(handle); - if (WARN_ON_ONCE(!aux)) + if (!aux) return; /* Inform user space new data arrived */ @@ -1599,7 +1599,7 @@ static void hw_collect_aux(struct cpu_hw_sf *cpuhw) debug_sprintf_event(sfdbg, 1, "AUX buffer used up\n"); break; } - if (WARN_ON_ONCE(!aux)) + if (!aux) return; /* Update head and alert_mark to new position */ @@ -1836,12 +1836,8 @@ static void cpumsf_pmu_start(struct perf_event *event, int flags) { struct cpu_hw_sf *cpuhw = this_cpu_ptr(&cpu_hw_sf); - if (WARN_ON_ONCE(!(event->hw.state & PERF_HES_STOPPED))) + if (!(event->hw.state & PERF_HES_STOPPED)) return; - - if (flags & PERF_EF_RELOAD) - WARN_ON_ONCE(!(event->hw.state & PERF_HES_UPTODATE)); - perf_pmu_disable(event->pmu); event->hw.state = 0; cpuhw->lsctl.cs = 1; -- 2.43.0