From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35DE554765; Wed, 6 Nov 2024 13:16:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730898997; cv=none; b=Mbo6gt+zCG6NCmdINYu4Hy99n1u+YX6nt0DXWg4nf6TvhodUZ2Kvq7PMNEJGlo24h6nDAV+qgFFvAZutiuatDGSJ5UCaziaA+DSkGcM6OIt3qRFksCytEsnRxOfxjAs0ubIar3qZTOwiYMIBStw7Xth45q3qkLUOe43oMN6vxW4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730898997; c=relaxed/simple; bh=v46+COC8VOpxxDt1xxoamZ6vD0QjFOeCXGhIavBYYRs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lUXu0uuUV2jE2X+0ulJe/v+3yJa7aj/vyi+dvhtLa/of9uE5AGLjbP5EC88CuhZrWjsReNWNnCHv3XOTX63Z3VwNxNp+1fJzaKDb57VKCcthGh+HE6dsxLFM/EVDacetySdDoVIA8MUzijaoln0XyStcT7BABk4PcRZp3JKjKJ4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=FleQxA1u; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="FleQxA1u" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B09A5C4CECD; Wed, 6 Nov 2024 13:16:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1730898997; bh=v46+COC8VOpxxDt1xxoamZ6vD0QjFOeCXGhIavBYYRs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FleQxA1uladDceBR9CYPOjoQ3QIzGFmoj5lwHohrTEqQeZIblpQ69YWJquStgDkkU GsixVI/2+/qJTGsZZfYTjIqDDO3KJNaEXFAD5LWv2JeG5PxqADFogHdJMc/AQAWQjK 3NVEsQJGtdB/WCZtk8o3GL5lfIb6FVJaR8ZUnIjY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Kalesh AP , Selvin Xavier , Jason Gunthorpe , Sasha Levin Subject: [PATCH 5.4 389/462] RDMA/bnxt_re: Return more meaningful error Date: Wed, 6 Nov 2024 13:04:42 +0100 Message-ID: <20241106120341.131950591@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241106120331.497003148@linuxfoundation.org> References: <20241106120331.497003148@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Kalesh AP [ Upstream commit 98647df0178df215b8239c5c365537283b2852a6 ] When the HWRM command fails, driver currently returns -EFAULT(Bad address). This does not look correct. Modified to return -EIO(I/O error). Fixes: cc1ec769b87c ("RDMA/bnxt_re: Fixing the Control path command and response handling") Fixes: 65288a22ddd8 ("RDMA/bnxt_re: use shadow qd while posting non blocking rcfw command") Link: https://patch.msgid.link/r/1728373302-19530-5-git-send-email-selvin.xavier@broadcom.com Signed-off-by: Kalesh AP Signed-off-by: Selvin Xavier Signed-off-by: Jason Gunthorpe Signed-off-by: Sasha Levin --- drivers/infiniband/hw/bnxt_re/qplib_rcfw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/bnxt_re/qplib_rcfw.c b/drivers/infiniband/hw/bnxt_re/qplib_rcfw.c index 5cdfa84faf85e..e74fb7c4d0335 100644 --- a/drivers/infiniband/hw/bnxt_re/qplib_rcfw.c +++ b/drivers/infiniband/hw/bnxt_re/qplib_rcfw.c @@ -244,7 +244,7 @@ int bnxt_qplib_rcfw_send_message(struct bnxt_qplib_rcfw *rcfw, /* failed with status */ dev_err(&rcfw->pdev->dev, "cmdq[%#x]=%#x status %#x\n", cookie, opcode, evnt->status); - rc = -EFAULT; + rc = -EIO; } return rc; -- 2.43.0