From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 145E42BB1B; Fri, 15 Nov 2024 06:59:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731653985; cv=none; b=LYJxF8QFFgYMAGo81ACeOvaCEvDXOYUdLw8vd9s8raivqlyPEIkMXzqvzarQPdQkqya2onGbEDYHDeNm5gp0d/mb2t215ue0raFw9znVLj36/Ssvc+HBSuOKROsBSwBffD6o5dj9YxNAUawP0krQAAizlrnakJf6HsZzZuKWIew= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731653985; c=relaxed/simple; bh=7ExGWzR7BWZA+jGs1YMnm/XvyASV9PL/S58qgnxa2bU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rIgdLRDqMHaaxQnUImKyboNcga6w3wv04uqEMKEFmAYR+nrSFKGFOsVMu1gccassGraBweAPkBeccaAvY6fqQy9oxdePRa4XBvTrN9xF5vtOewjQNZRSndAjG46daSibHoqiypkx/m7LK1IAeUilzshpWU3lYcrbJZmHXbDieOI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=cq1DmxTP; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="cq1DmxTP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 400FEC4CECF; Fri, 15 Nov 2024 06:59:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1731653984; bh=7ExGWzR7BWZA+jGs1YMnm/XvyASV9PL/S58qgnxa2bU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cq1DmxTPBDjRpJDvS5GomC4BJ8/NLvPe6Yh8+7VQ7oTQ2zg7gHOsr5XKH+exXg+rO JjNM0OpQVsSKQ3uicOlfEVe/f9BBMNfGJ+KB3H1p4242lJTlQysKkZyALVCj3MTQ2Y 1ig0vOAElr1ZNtc8TgCREKOT4guinhT11z182aFA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yuan Can , "Michael S. Tsirkin" , Jason Wang , Zhu Lingshan , Sasha Levin Subject: [PATCH 5.15 11/22] vDPA/ifcvf: Fix pci_read_config_byte() return code handling Date: Fri, 15 Nov 2024 07:38:57 +0100 Message-ID: <20241115063721.582255183@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241115063721.172791419@linuxfoundation.org> References: <20241115063721.172791419@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yuan Can [ Upstream commit 7f8825b2a78ac392d3fbb3a2e65e56d9e39d75e9 ] ifcvf_init_hw() uses pci_read_config_byte() that returns PCIBIOS_* codes. The error handling, however, assumes the codes are normal errnos because it checks for < 0. Convert the error check to plain non-zero check. Fixes: 5a2414bc454e ("virtio: Intel IFC VF driver for VDPA") Signed-off-by: Yuan Can Message-Id: <20241017013812.129952-1-yuancan@huawei.com> Signed-off-by: Michael S. Tsirkin Acked-by: Jason Wang Acked-by: Zhu Lingshan Signed-off-by: Sasha Levin --- drivers/vdpa/ifcvf/ifcvf_base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vdpa/ifcvf/ifcvf_base.c b/drivers/vdpa/ifcvf/ifcvf_base.c index 5091ff9d6c93f..bdadc5714e0e4 100644 --- a/drivers/vdpa/ifcvf/ifcvf_base.c +++ b/drivers/vdpa/ifcvf/ifcvf_base.c @@ -105,7 +105,7 @@ int ifcvf_init_hw(struct ifcvf_hw *hw, struct pci_dev *pdev) u32 i; ret = pci_read_config_byte(pdev, PCI_CAPABILITY_LIST, &pos); - if (ret < 0) { + if (ret) { IFCVF_ERR(pdev, "Failed to read PCI capability list\n"); return -EIO; } -- 2.43.0