From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C30001F4283; Tue, 3 Dec 2024 14:57:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733237877; cv=none; b=Kdj1BopjjBKNxOm1RkwuFsz4rX97hBNRZcUUu9lbunDhsDgwc0He+kP5jKRWOZrdt2mUEOVNzsn/0xLas9G4f6mpd2w/cnNJ/IlhCtI2/Lw408PCt3UEVJI2z5rB/fFRLRT41ji8Pys86gocK+pjojQ+Yv+zh22FVJirnwYIC/I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733237877; c=relaxed/simple; bh=wRlRHxYwS6lrfoNxSvL6jdL6pmlhICnr25KfFW4uXzE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MRdNyuIjKDkCjLTAkLUVMuuFry++DfyjnCE39mxsViMQ475egFGleoSTMAwtWbT5A941fLO37kIEOO97ZBGYAFm5xddhLSnA1zcgMeKurl1XFKpg99CgXqOVLmdNY7SE6333NcExTXUTcgfwMFmvd9daTqjLR0OlRini4GHVlB8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=roIMawGN; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="roIMawGN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 29AC3C4CECF; Tue, 3 Dec 2024 14:57:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1733237877; bh=wRlRHxYwS6lrfoNxSvL6jdL6pmlhICnr25KfFW4uXzE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=roIMawGNMI3WQampYXv438BTDSfuidJyf5E2HvPy4lQVOIqdF7c/ryjVBfu/WCjvx 5uLEh3Ez+ZUa6oDr+1C8QN3XBrcoqDfRwrvQHUGAIBoB9QH3DF5p00IqSGXcZIdMBU rwc61W/AUB8JDcBmH+efgP45x5xvtBUfMwv3k2r0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Dan Carpenter , Giovanni Cabiddu , Herbert Xu , Sasha Levin Subject: [PATCH 6.11 094/817] crypto: qat/qat_4xxx - fix off by one in uof_get_name() Date: Tue, 3 Dec 2024 15:34:26 +0100 Message-ID: <20241203143959.374084255@linuxfoundation.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241203143955.605130076@linuxfoundation.org> References: <20241203143955.605130076@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.11-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dan Carpenter [ Upstream commit 475b5098043eef6e72751aadeab687992a5b63d1 ] The fw_objs[] array has "num_objs" elements so the > needs to be >= to prevent an out of bounds read. Fixes: 10484c647af6 ("crypto: qat - refactor fw config logic for 4xxx") Signed-off-by: Dan Carpenter Acked-by: Giovanni Cabiddu Signed-off-by: Herbert Xu Signed-off-by: Sasha Levin --- drivers/crypto/intel/qat/qat_4xxx/adf_4xxx_hw_data.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/intel/qat/qat_4xxx/adf_4xxx_hw_data.c b/drivers/crypto/intel/qat/qat_4xxx/adf_4xxx_hw_data.c index 9fd7ec53b9f3d..bbd92c017c28e 100644 --- a/drivers/crypto/intel/qat/qat_4xxx/adf_4xxx_hw_data.c +++ b/drivers/crypto/intel/qat/qat_4xxx/adf_4xxx_hw_data.c @@ -334,7 +334,7 @@ static const char *uof_get_name(struct adf_accel_dev *accel_dev, u32 obj_num, else id = -EINVAL; - if (id < 0 || id > num_objs) + if (id < 0 || id >= num_objs) return NULL; return fw_objs[id]; -- 2.43.0