From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5EADEBA34; Mon, 6 Jan 2025 15:59:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736179145; cv=none; b=NK/ZvPDNXgY5LYF3524peJQ6dxK3DCUv7z+DZGxGftJHLwbKEGYrTD2W/IbPxetMpJAXwc7jUkuDRI/S4K7l4e16LA2kD2uTk9SHh3SfCZp3TKaqj4OhO5wUHt05UsTJ7EPKVXup6pYTkHGRuVr2B7TUBoY0U7R/E3BsRh+v2+g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736179145; c=relaxed/simple; bh=nhjJfQn/SrkmfFcxVC0cj6nuc+uAancxaTuijZOqj7Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=vGfeXkZbl8T9EiI9/jr8hZfQ8gwaDwyAgaegWK61TXtpblo5KA6DdwABcTATFqt85lbF+QKK7UEeZib6IM1+USQGq7WmGpb6497yKhGmZY7RqyU2FyGcvGS6v0wLJB1Ei+pUdXgEGTvVa+s0NdAm78x+17WxjEO8C0F1/KNqzyA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=HtXLkKHu; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="HtXLkKHu" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6824DC4CED2; Mon, 6 Jan 2025 15:59:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1736179145; bh=nhjJfQn/SrkmfFcxVC0cj6nuc+uAancxaTuijZOqj7Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HtXLkKHuHgfoOWReFngN8W8VqNTip5EMQL2l1Z4LITSiaQoAzRR21NUMBSvn8GWSE hyHHAq2yArsBgaxekUt9M7lKAGPkO0ZyMpc16pxO5dztthzotxCVHyj78FaZ9TdEiA i7uwubja1Gvn7rNXR8KihzTpHWilJfo/axhJxZkY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Johan Hovold , Zijun Hu , Vinod Koul Subject: [PATCH 5.4 40/93] phy: core: Fix that API devm_phy_destroy() fails to destroy the phy Date: Mon, 6 Jan 2025 16:17:16 +0100 Message-ID: <20250106151130.214737636@linuxfoundation.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250106151128.686130933@linuxfoundation.org> References: <20250106151128.686130933@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Zijun Hu commit 4dc48c88fcf82b89fdebd83a906aaa64f40fb8a9 upstream. For devm_phy_destroy(), its comment says it needs to invoke phy_destroy() to destroy the phy, but it will not actually invoke the function since devres_destroy() does not call devm_phy_consume(), and the missing phy_destroy() call will cause that the phy fails to be destroyed. Fortunately, the faulty API has not been used by current kernel tree. Fix by using devres_release() instead of devres_destroy() within the API. Fixes: ff764963479a ("drivers: phy: add generic PHY framework") Reviewed-by: Johan Hovold Signed-off-by: Zijun Hu Link: https://lore.kernel.org/r/20241213-phy_core_fix-v6-3-40ae28f5015a@quicinc.com Signed-off-by: Vinod Koul Signed-off-by: Greg Kroah-Hartman --- drivers/phy/phy-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/phy/phy-core.c +++ b/drivers/phy/phy-core.c @@ -958,7 +958,7 @@ void devm_phy_destroy(struct device *dev { int r; - r = devres_destroy(dev, devm_phy_consume, devm_phy_match, phy); + r = devres_release(dev, devm_phy_consume, devm_phy_match, phy); dev_WARN_ONCE(dev, r, "couldn't find PHY resource\n"); } EXPORT_SYMBOL_GPL(devm_phy_destroy);