From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCEA11D9595; Mon, 6 Jan 2025 16:00:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736179232; cv=none; b=OggTV4gTCiSlfpa/fbI/fSalbWGL3VXM2rzZ+Is3ssHWmWoNcMTAm1x76ygP2V2dSiZjHMU9jEaYqQ+PgZOsG7wo9p3aSEwWjbc2XT1Ln+oL/EYgI/jCFxbkX76JQOIYIyDENMmS9cRNhFqAkJ4Ls9oH5ZYtphRPu5urzHFYz6M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736179232; c=relaxed/simple; bh=KfAuWX5Gey273nbhFBRHn9bIITgQ/14n2lZVtgDRISE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OazO36a98Upf5YbgZyRWIa4TbA1fpO5MvnTW+uOPdq6w5IyxVHKbJ9wIWG6CzDUtnyq9M1K5AaOWh4jjarH4zkRerpOVFoy9cI9X+HrpeFGewgfhemjcOClO6BAt6MtbDTKYVwXgTD0YglwZGhaqH7uip/dv/wASnOhVKgNKa+Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=RcPKG9Dd; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="RcPKG9Dd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A1F16C4CED2; Mon, 6 Jan 2025 16:00:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1736179231; bh=KfAuWX5Gey273nbhFBRHn9bIITgQ/14n2lZVtgDRISE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RcPKG9Dd/B17gWClN1aE064RNgnX5YFiEnxrt3E7bFMwKlh574JYNZO5lCm6ZM3sL dmR2EgyAnljc1H/x23UkfLnN2pllOuMh1VHgJCPl8jh2Bi3yIsbhVuR8UK4BbquPUo tqJ24chNO6yW9PZcxMxo+s+JxaLGg4JQI2PNnOFM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Devesh Sharma , Selvin Xavier , Jason Gunthorpe , Sasha Levin Subject: [PATCH 5.4 69/93] RDMA/bnxt_re: Fix max_qp_wrs reported Date: Mon, 6 Jan 2025 16:17:45 +0100 Message-ID: <20250106151131.308991599@linuxfoundation.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250106151128.686130933@linuxfoundation.org> References: <20250106151128.686130933@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Selvin Xavier [ Upstream commit c63e1c4dfc33d1bdae395ee8fbcbfad4830b12c0 ] While creating qps, the driver adds one extra entry to the sq size passed by the ULPs in order to avoid queue full condition. When ULPs creates QPs with max_qp_wr reported, driver creates QP with 1 more than the max_wqes supported by HW. Create QP fails in this case. To avoid this error, reduce 1 entry in max_qp_wqes and report it to the stack. Link: https://lore.kernel.org/r/1606741986-16477-1-git-send-email-selvin.xavier@broadcom.com Signed-off-by: Devesh Sharma Signed-off-by: Selvin Xavier Signed-off-by: Jason Gunthorpe Signed-off-by: Sasha Levin --- drivers/infiniband/hw/bnxt_re/qplib_sp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/bnxt_re/qplib_sp.c b/drivers/infiniband/hw/bnxt_re/qplib_sp.c index 079aaaaffec7..f623f881a95b 100644 --- a/drivers/infiniband/hw/bnxt_re/qplib_sp.c +++ b/drivers/infiniband/hw/bnxt_re/qplib_sp.c @@ -118,7 +118,7 @@ int bnxt_qplib_get_dev_attr(struct bnxt_qplib_rcfw *rcfw, * 128 WQEs needs to be reserved for the HW (8916). Prevent * reporting the max number */ - attr->max_qp_wqes -= BNXT_QPLIB_RESERVED_QP_WRS; + attr->max_qp_wqes -= BNXT_QPLIB_RESERVED_QP_WRS + 1; attr->max_qp_sges = bnxt_qplib_is_chip_gen_p5(rcfw->res->cctx) ? 6 : sb->max_sge; attr->max_cq = le32_to_cpu(sb->max_cq); -- 2.39.5