From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 970694A35; Thu, 30 Jan 2025 06:48:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738219682; cv=none; b=CNYgsPNno1hlsVY2RYGbJ1ZX8suH3sU6KK+hCfgbAZloEwqBk581+wTmoTc0gvyTYs204uPiTKQmWMkrD5V3GqcyorPcCG73zcnSKwrakRrwyn6XlTmc03JmHc5hmBsyTqOni55UnIrsZGqxJlXeh3Hf72lO1zageD8kegqEIAk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738219682; c=relaxed/simple; bh=hA8VQ1eoTeywda7EOBK+TZgVj+hQPhL7fA8MlFXWnYg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lmxZqRzm8KpP3h+VFgTpkFBMMIo5ktFMD+Lh38yKqaacPxUYYqBXqhuarKChVmUE8iEQ4cBYqfXOBQXR9SBddn3vZ1vIccapeTcahkIqnsqD3A2kpSvq90tv7L0zpAzlsVXpfLAYF5YsGjZxlBbw2mpuvrF1tv+cI6N+5jrdJSg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Xm5qooNe; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Xm5qooNe" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C54EC4CED3; Thu, 30 Jan 2025 06:48:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1738219682; bh=hA8VQ1eoTeywda7EOBK+TZgVj+hQPhL7fA8MlFXWnYg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Xm5qooNegc2EGsTO5wCXz2b6wpL1PTnVNLorhB68Zl7KnQaXUeZ82n/KOj3X2W47h OHZ8XeVj/IBffVMIo0QWWBLWa106hkSb2Vjj3ht5jJX1FzBdkZqRyEuS/JlY8U7gqA B4WmE6408Zq912uqEIWPnTc4ODpb+xvrK+B15AEU= Date: Thu, 30 Jan 2025 07:47:59 +0100 From: Greg KH To: Alex Deucher Cc: Nathan Chancellor , Chaitanya Dhere , Jun Lei , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , Xinhui Pan , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, llvm@lists.linux.dev, patches@lists.linux.dev, kernel test robot Subject: Re: [PATCH] drm/amd/display: Increase sanitizer frame larger than limit when compile testing with clang Message-ID: <2025013058-fasting-gibberish-9718@gregkh> References: <20241219-amdgpu-dml2-address-clang-frame-larger-than-allconfig-v1-1-8c53a644d486@kernel.org> Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Jan 06, 2025 at 12:29:32PM -0500, Alex Deucher wrote: > Applied. Thanks! Thanks, but I am still getting this error on Linus's current tree right now, with this commit applied: CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/display_mode_core.o drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/display_mode_core.c:6713:12: error: stack frame size (2056) exceeds limit (2048) in 'dml_core_mode_support' [-Werror,-Wframe-larger-than] 6713 | dml_bool_t dml_core_mode_support(struct display_mode_lib_st *mode_lib) | ^ 1 error generated. I think the issue is: > > --- a/drivers/gpu/drm/amd/display/dc/dml2/Makefile > > +++ b/drivers/gpu/drm/amd/display/dc/dml2/Makefile > > @@ -29,7 +29,11 @@ dml2_rcflags := $(CC_FLAGS_NO_FPU) > > > > ifneq ($(CONFIG_FRAME_WARN),0) > > ifeq ($(filter y,$(CONFIG_KASAN)$(CONFIG_KCSAN)),y) I do not have CONFIG_KASAN or CONFIG_KCSAN enabled, but I do have: > > +ifeq ($(CONFIG_CC_IS_CLANG)$(CONFIG_COMPILE_TEST),yy) These two options enabled, and for some reason: CONFIG_FRAME_WARN=2048 as well. Ah, 2048 is the default value, that's how. So this warning triggers even without KASAN or KCSAN being enabled, is that to be expected? Is the stack really being used that much here? I'll go bump FRAME_WARN up to get some local testing working again, but odds are others are going to hit this if I am in my "normal" build tests. thanks, greg k-h