From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BD041EDA36; Wed, 19 Feb 2025 08:55:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739955357; cv=none; b=CdzrNbWW55gZTiRqQKQM7kiF5gXRindDEJs5PiCf1VSZ+bGk8gZtZ7O2qZg7sy7yVhZQ1bbVlRsouclnMIYvTSzKbqd8o0sGWU+bpHbAMc9aGWjrVIUDjhDfWWpVDsR8kutvQLeUbswdgymo47rMsImkXJ5ARGuYsEEU733gJV4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739955357; c=relaxed/simple; bh=toQVNSNnumYiooo/rLX6p00U1fvRbD9fEP0cyQp7TAQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=TWq+Cf/XovM3UANfczQxoKTbwu9FDfeZB64WtuwJbO5LjELQp0HnRmpMNYBpEv5oOZvpHtokQP+sY4U97Bc4XXLXGrGESDhx/83XiatsL/TaJ3Ohct29b0v8nWTvH6OY4kSQxyFe/YWWpecxlE7L5uM88aZNrPUJSHIm61hZejc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=mJNpEE9A; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="mJNpEE9A" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 87566C4CEE7; Wed, 19 Feb 2025 08:55:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1739955356; bh=toQVNSNnumYiooo/rLX6p00U1fvRbD9fEP0cyQp7TAQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mJNpEE9AeL0cZd6pZTbl57Uo5iNtxTbsCu4zsNEpxh2/rE/9/ZnJ9/eDahxKMbnlx qHa+JKzglllahIKkWL1ATcOB/h2oLFl2TJ89IA3Sk/xsowwqrINwRpQUtcNyDcNVHV CPTl9UQWNgOhcgBYeptakHWSgAQ+ZQkVTSFuHmig= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Leonard Lausen , =?UTF-8?q?Gy=C3=B6rgy=20Kurucz?= , Johan Hovold , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang Subject: [PATCH 6.12 211/230] drm/msm/dpu1: dont choke on disabling the writeback connector Date: Wed, 19 Feb 2025 09:28:48 +0100 Message-ID: <20250219082609.946707026@linuxfoundation.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250219082601.683263930@linuxfoundation.org> References: <20250219082601.683263930@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dmitry Baryshkov commit d9f55e2abfb933818c772eba659a9b7ab28a44d0 upstream. During suspend/resume process all connectors are explicitly disabled and then reenabled. However resume fails because of the connector_status check: [dpu error]connector not connected 3 [drm:drm_mode_config_helper_resume [drm_kms_helper]] *ERROR* Failed to resume (-22) It doesn't make sense to check for the Writeback connected status (and other drivers don't perform such check), so drop the check. It wasn't a problem before the commit 71174f362d67 ("drm/msm/dpu: move writeback's atomic_check to dpu_writeback.c"), since encoder's atomic_check() is called under a different conditions that the connector's atomic_check() (e.g. it is not called if there is no connected CRTC or if the corresponding connector is not a part of the new state). Fixes: 71174f362d67 ("drm/msm/dpu: move writeback's atomic_check to dpu_writeback.c") Cc: stable@vger.kernel.org Reported-by: Leonard Lausen Closes: https://gitlab.freedesktop.org/drm/msm/-/issues/57 Tested-by: Leonard Lausen # on sc7180 lazor Tested-by: György Kurucz Reviewed-by: Johan Hovold Tested-by: Johan Hovold Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar Tested-by: Jessica Zhang # Trogdor (sc7180) Patchwork: https://patchwork.freedesktop.org/patch/627828/ Link: https://lore.kernel.org/r/20241209-dpu-fix-wb-v4-1-7fe93059f9e0@linaro.org Signed-off-by: Abhinav Kumar Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c | 3 --- 1 file changed, 3 deletions(-) --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c @@ -42,9 +42,6 @@ static int dpu_wb_conn_atomic_check(stru if (!conn_state || !conn_state->connector) { DPU_ERROR("invalid connector state\n"); return -EINVAL; - } else if (conn_state->connector->status != connector_status_connected) { - DPU_ERROR("connector not connected %d\n", conn_state->connector->status); - return -EINVAL; } crtc = conn_state->crtc;