From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: stable@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
patches@lists.linux.dev, Sven Eckelmann <sven@narfation.org>,
Simon Wunderlich <sw@simonwunderlich.de>
Subject: [PATCH 6.12 086/116] batman-adv: Ignore own maximum aggregation size during RX
Date: Tue, 25 Mar 2025 08:22:53 -0400 [thread overview]
Message-ID: <20250325122151.410156772@linuxfoundation.org> (raw)
In-Reply-To: <20250325122149.207086105@linuxfoundation.org>
6.12-stable review patch. If anyone has any objections, please let me know.
------------------
From: Sven Eckelmann <sven@narfation.org>
commit 548b0c5de7619ef53bbde5590700693f2f6d2a56 upstream.
An OGMv1 and OGMv2 packet receive processing were not only limited by the
number of bytes in the received packet but also by the nodes maximum
aggregation packet size limit. But this limit is relevant for TX and not
for RX. It must not be enforced by batadv_(i)v_ogm_aggr_packet to avoid
loss of information in case of a different limit for sender and receiver.
This has a minor side effect for B.A.T.M.A.N. IV because the
batadv_iv_ogm_aggr_packet is also used for the preprocessing for the TX.
But since the aggregation code itself will not allow more than
BATADV_MAX_AGGREGATION_BYTES bytes, this check was never triggering (in
this context) prior of removing it.
Cc: stable@vger.kernel.org
Fixes: c6c8fea29769 ("net: Add batman-adv meshing protocol")
Fixes: 9323158ef9f4 ("batman-adv: OGMv2 - implement originators logic")
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
net/batman-adv/bat_iv_ogm.c | 3 +--
net/batman-adv/bat_v_ogm.c | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
--- a/net/batman-adv/bat_iv_ogm.c
+++ b/net/batman-adv/bat_iv_ogm.c
@@ -324,8 +324,7 @@ batadv_iv_ogm_aggr_packet(int buff_pos,
/* check if there is enough space for the optional TVLV */
next_buff_pos += ntohs(ogm_packet->tvlv_len);
- return (next_buff_pos <= packet_len) &&
- (next_buff_pos <= BATADV_MAX_AGGREGATION_BYTES);
+ return next_buff_pos <= packet_len;
}
/* send a batman ogm to a given interface */
--- a/net/batman-adv/bat_v_ogm.c
+++ b/net/batman-adv/bat_v_ogm.c
@@ -839,8 +839,7 @@ batadv_v_ogm_aggr_packet(int buff_pos, i
/* check if there is enough space for the optional TVLV */
next_buff_pos += ntohs(ogm2_packet->tvlv_len);
- return (next_buff_pos <= packet_len) &&
- (next_buff_pos <= BATADV_MAX_AGGREGATION_BYTES);
+ return next_buff_pos <= packet_len;
}
/**
next prev parent reply other threads:[~2025-03-25 12:39 UTC|newest]
Thread overview: 123+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-25 12:21 [PATCH 6.12 000/116] 6.12.21-rc1 review Greg Kroah-Hartman
2025-03-25 12:21 ` [PATCH 6.12 001/116] firmware: qcom: scm: Fix error code in probe() Greg Kroah-Hartman
2025-03-25 12:21 ` [PATCH 6.12 002/116] firmware: imx-scu: fix OF node leak in .probe() Greg Kroah-Hartman
2025-03-25 12:21 ` [PATCH 6.12 003/116] arm64: dts: freescale: tqma8mpql: Fix vqmmc-supply Greg Kroah-Hartman
2025-03-25 12:21 ` [PATCH 6.12 004/116] arm64: dts: rockchip: remove supports-cqe from rk3588 jaguar Greg Kroah-Hartman
2025-03-25 12:21 ` [PATCH 6.12 005/116] arm64: dts: rockchip: remove supports-cqe from rk3588 tiger Greg Kroah-Hartman
2025-03-25 12:21 ` [PATCH 6.12 006/116] xfrm: fix tunnel mode TX datapath in packet offload mode Greg Kroah-Hartman
2025-03-25 12:21 ` [PATCH 6.12 007/116] xfrm_output: Force software GSO only in tunnel mode Greg Kroah-Hartman
2025-03-25 12:21 ` [PATCH 6.12 008/116] soc: imx8m: Remove global soc_uid Greg Kroah-Hartman
2025-03-25 12:21 ` [PATCH 6.12 009/116] soc: imx8m: Use devm_* to simplify probe failure handling Greg Kroah-Hartman
2025-03-25 12:21 ` [PATCH 6.12 010/116] soc: imx8m: Unregister cpufreq and soc dev in cleanup path Greg Kroah-Hartman
2025-03-25 12:21 ` [PATCH 6.12 011/116] ARM: dts: bcm2711: Fix xHCI power-domain Greg Kroah-Hartman
2025-03-25 12:21 ` [PATCH 6.12 012/116] ARM: dts: bcm2711: PL011 UARTs are actually r1p5 Greg Kroah-Hartman
2025-03-25 12:21 ` [PATCH 6.12 013/116] arm64: dts: bcm2712: " Greg Kroah-Hartman
2025-03-25 12:21 ` [PATCH 6.12 014/116] arm64: dts: rockchip: Remove undocumented sdmmc property from lubancat-1 Greg Kroah-Hartman
2025-03-25 12:21 ` [PATCH 6.12 015/116] RDMA/rxe: Fix the failure of ibv_query_device() and ibv_query_device_ex() tests Greg Kroah-Hartman
2025-03-25 12:21 ` [PATCH 6.12 016/116] RDMA/bnxt_re: Add missing paranthesis in map_qp_id_to_tbl_indx Greg Kroah-Hartman
2025-03-25 12:21 ` [PATCH 6.12 017/116] RDMA/mlx5: Handle errors returned from mlx5r_ib_rate() Greg Kroah-Hartman
2025-03-25 12:21 ` [PATCH 6.12 018/116] ARM: OMAP1: select CONFIG_GENERIC_IRQ_CHIP Greg Kroah-Hartman
2025-03-25 12:21 ` [PATCH 6.12 019/116] ARM: dts: bcm2711: Dont mark timer regs unconfigured Greg Kroah-Hartman
2025-03-25 12:21 ` [PATCH 6.12 020/116] ARM: dts: BCM5301X: Fix switch port labels of ASUS RT-AC5300 Greg Kroah-Hartman
2025-03-25 12:21 ` [PATCH 6.12 021/116] ARM: dts: BCM5301X: Fix switch port labels of ASUS RT-AC3200 Greg Kroah-Hartman
2025-03-25 12:21 ` [PATCH 6.12 022/116] dma-mapping: fix missing clear bdr in check_ram_in_range_map() Greg Kroah-Hartman
2025-03-25 12:21 ` [PATCH 6.12 023/116] RDMA/bnxt_re: Avoid clearing VLAN_ID mask in modify qp path Greg Kroah-Hartman
2025-03-25 12:21 ` [PATCH 6.12 024/116] RDMA/hns: Fix soft lockup during bt pages loop Greg Kroah-Hartman
2025-03-25 12:21 ` [PATCH 6.12 025/116] RDMA/hns: Fix unmatched condition in error path of alloc_user_qp_db() Greg Kroah-Hartman
2025-03-25 12:21 ` [PATCH 6.12 026/116] RDMA/hns: Fix invalid sq params not being blocked Greg Kroah-Hartman
2025-03-25 12:21 ` [PATCH 6.12 027/116] RDMA/hns: Fix a missing rollback in error path of hns_roce_create_qp_common() Greg Kroah-Hartman
2025-03-25 12:21 ` [PATCH 6.12 028/116] RDMA/hns: Fix missing xa_destroy() Greg Kroah-Hartman
2025-03-25 12:21 ` [PATCH 6.12 029/116] RDMA/hns: Fix wrong value of max_sge_rd Greg Kroah-Hartman
2025-03-25 12:21 ` [PATCH 6.12 030/116] Bluetooth: Fix error code in chan_alloc_skb_cb() Greg Kroah-Hartman
2025-03-25 12:21 ` [PATCH 6.12 031/116] Bluetooth: hci_event: Fix connection regression between LE and non-LE adapters Greg Kroah-Hartman
2025-03-25 12:21 ` [PATCH 6.12 032/116] accel/qaic: Fix possible data corruption in BOs > 2G Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 033/116] ARM: davinci: da850: fix selecting ARCH_DAVINCI_DA8XX Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 034/116] tracing: tprobe-events: Fix to clean up tprobe correctly when module unload Greg Kroah-Hartman
2025-11-24 11:06 ` Khannanov Lenar
2025-12-02 22:19 ` Masami Hiramatsu
2025-03-25 12:22 ` [PATCH 6.12 035/116] ata: libata-core: Add ATA_QUIRK_NO_LPM_ON_ATI for certain Samsung SSDs Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 036/116] net: ethernet: ti: am65-cpsw: Fix NAPI registration sequence Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 037/116] net: ipv6: fix TCP GSO segmentation with NAT Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 038/116] ipv6: Fix memleak of nhc_pcpu_rth_output in fib_check_nh_v6_gw() Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 039/116] ipv6: Set errno after ip_fib_metrics_init() in ip6_route_info_create() Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 040/116] devlink: fix xa_alloc_cyclic() error handling Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 041/116] dpll: " Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 042/116] phy: " Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 043/116] gpu: host1x: Do not assume that a NULL domain means no DMA IOMMU Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 044/116] net: atm: fix use after free in lec_send() Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 045/116] net: ti: icssg-prueth: Add lock to stats Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 046/116] net: lwtunnel: fix recursion loops Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 047/116] net: ipv6: ioam6: fix lwtunnel_output() loop Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 048/116] libfs: Fix duplicate directory entry in offset_dir_lookup Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 049/116] net/neighbor: add missing policy for NDTPA_QUEUE_LENBYTES Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 050/116] Revert "gre: Fix IPv6 link-local address generation." Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 051/116] tracing: tprobe-events: Fix leakage of module refcount Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 052/116] i2c: omap: fix IRQ storms Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 053/116] net: mana: Support holes in device list reply msg Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 054/116] dt-bindings: can: renesas,rcar-canfd: Fix typo in pattern properties for R-Car V4M Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 055/116] can: rcar_canfd: Fix page entries in the AFL list Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 056/116] can: ucan: fix out of bound read in strscpy() source Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 057/116] can: flexcan: only change CAN state when link up in system PM Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 058/116] can: flexcan: disable transceiver during " Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 059/116] drm/xe: Fix exporting xe buffers multiple times Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 060/116] drm/v3d: Dont run jobs that have errors flagged in its fence Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 061/116] io_uring/net: dont clear REQ_F_NEED_CLEANUP unconditionally Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 062/116] riscv: dts: starfive: Fix a typo in StarFive JH7110 pin function definitions Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 063/116] netfs: Call `invalidate_cache` only if implemented Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 064/116] regulator: dummy: force synchronous probing Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 065/116] regulator: check that dummy regulator has been probed before using it Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 066/116] accel/qaic: Fix integer overflow in qaic_validate_req() Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 067/116] arm64: dts: freescale: imx8mp-verdin-dahlia: add Microphone Jack to sound card Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 068/116] arm64: dts: freescale: imx8mm-verdin-dahlia: " Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 069/116] arm64: dts: rockchip: fix pinmux of UART0 for PX30 Ringneck on Haikou Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 070/116] arm64: dts: rockchip: fix pinmux of UART5 " Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 071/116] arm64: dts: rockchip: Add missing PCIe supplies to RockPro64 board dtsi Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 072/116] mmc: sdhci-brcmstb: add cqhci suspend/resume to PM ops Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 073/116] mmc: atmel-mci: Add missing clk_disable_unprepare() Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 074/116] selftests/mm: run_vmtests.sh: fix half_ufd_size_MB calculation Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 075/116] mm: fix error handling in __filemap_get_folio() with FGP_NOWAIT Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 076/116] mm/migrate: fix shmem xarray update during migration Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 077/116] mm/page_alloc: fix memory accept before watermarks gets initialized Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 078/116] proc: fix UAF in proc_get_inode() Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 079/116] memcg: drain obj stock on cpu hotplug teardown Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 080/116] ARM: dts: imx6qdl-apalis: Fix poweroff on Apalis iMX6 Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 081/116] ARM: shmobile: smp: Enforce shmobile_smp_* alignment Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 082/116] firmware: qcom: uefisecapp: fix efivars registration race Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 083/116] efi/libstub: Avoid physical address 0x0 when doing random allocation Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 084/116] keys: Fix UAF in key_put() Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 085/116] xsk: fix an integer overflow in xp_create_and_assign_umem() Greg Kroah-Hartman
2025-03-25 12:22 ` Greg Kroah-Hartman [this message]
2025-03-25 12:22 ` [PATCH 6.12 087/116] soc: qcom: pdr: Fix the potential deadlock Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 088/116] pmdomain: amlogic: fix T7 ISP secpower Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 089/116] drm/radeon: fix uninitialized size issue in radeon_vce_cs_parse() Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 090/116] drm/sched: Fix fence reference count leak Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 091/116] drm/amdgpu/gfx12: correct cleanup of me field with gfx_v12_0_me_fini() Greg Kroah-Hartman
2025-03-25 12:22 ` [PATCH 6.12 092/116] drm/amd/display: Fix message for support_edp0_on_dp1 Greg Kroah-Hartman
2025-03-25 12:23 ` [PATCH 6.12 093/116] drm/amd/display: Use HW lock mgr for PSR1 when only one eDP Greg Kroah-Hartman
2025-03-25 12:23 ` [PATCH 6.12 094/116] drm/amd/pm: add unique_id for gfx12 Greg Kroah-Hartman
2025-03-25 12:23 ` [PATCH 6.12 095/116] drm/amdgpu: Restore uncached behaviour on GFX12 Greg Kroah-Hartman
2025-03-25 12:23 ` [PATCH 6.12 096/116] drm/amdgpu/pm: Handle SCLK offset correctly in overdrive for smu 14.0.2 Greg Kroah-Hartman
2025-03-25 12:23 ` [PATCH 6.12 097/116] drm/amdgpu/pm: wire up hwmon fan speed " Greg Kroah-Hartman
2025-03-25 12:23 ` [PATCH 6.12 098/116] drm/amdgpu: Remove JPEG from vega and carrizo video caps Greg Kroah-Hartman
2025-03-25 12:23 ` [PATCH 6.12 099/116] drm/amdgpu: Fix MPEG2, MPEG4 and VC1 video caps max size Greg Kroah-Hartman
2025-03-25 12:23 ` [PATCH 6.12 100/116] drm/amdgpu: Fix JPEG video caps max size for navi1x and raven Greg Kroah-Hartman
2025-03-25 12:23 ` [PATCH 6.12 101/116] drm/amdkfd: Fix user queue validation on Gfx7/8 Greg Kroah-Hartman
2025-03-25 12:23 ` [PATCH 6.12 102/116] ksmbd: fix incorrect validation for num_aces field of smb_acl Greg Kroah-Hartman
2025-03-25 12:23 ` [PATCH 6.12 103/116] io_uring/net: fix sendzc double notif flush Greg Kroah-Hartman
2025-03-25 12:23 ` [PATCH 6.12 104/116] KVM: arm64: Calculate cptr_el2 traps on activating traps Greg Kroah-Hartman
2025-03-25 12:23 ` [PATCH 6.12 105/116] KVM: arm64: Unconditionally save+flush host FPSIMD/SVE/SME state Greg Kroah-Hartman
2025-03-25 12:23 ` [PATCH 6.12 106/116] KVM: arm64: Remove host FPSIMD saving for non-protected KVM Greg Kroah-Hartman
2025-03-25 12:23 ` [PATCH 6.12 107/116] KVM: arm64: Remove VHE host restore of CPACR_EL1.ZEN Greg Kroah-Hartman
2025-03-25 12:23 ` [PATCH 6.12 108/116] KVM: arm64: Remove VHE host restore of CPACR_EL1.SMEN Greg Kroah-Hartman
2025-03-25 12:23 ` [PATCH 6.12 109/116] KVM: arm64: Refactor exit handlers Greg Kroah-Hartman
2025-03-25 12:23 ` [PATCH 6.12 110/116] KVM: arm64: Mark some header functions as inline Greg Kroah-Hartman
2025-03-25 12:23 ` [PATCH 6.12 111/116] KVM: arm64: Eagerly switch ZCR_EL{1,2} Greg Kroah-Hartman
2025-03-25 12:23 ` [PATCH 6.12 112/116] Revert "sched/core: Reduce cost of sched_move_task when config autogroup" Greg Kroah-Hartman
2025-03-25 12:23 ` [PATCH 6.12 113/116] libsubcmd: Silence compiler warning Greg Kroah-Hartman
2025-03-25 12:23 ` [PATCH 6.12 114/116] arm64: dts: rockchip: fix u2phy1_host status for NanoPi R4S Greg Kroah-Hartman
2025-03-25 12:23 ` [PATCH 6.12 115/116] mm/huge_memory: drop beyond-EOF folios with the right number of refs Greg Kroah-Hartman
2025-03-25 12:23 ` [PATCH 6.12 116/116] mptcp: Fix data stream corruption in the address announcement Greg Kroah-Hartman
2025-03-25 16:14 ` [PATCH 6.12 000/116] 6.12.21-rc1 review Naresh Kamboju
2025-03-25 17:38 ` Florian Fainelli
2025-03-25 18:26 ` Miguel Ojeda
2025-03-25 20:07 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250325122151.410156772@linuxfoundation.org \
--to=gregkh@linuxfoundation.org \
--cc=patches@lists.linux.dev \
--cc=stable@vger.kernel.org \
--cc=sven@narfation.org \
--cc=sw@simonwunderlich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).