From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20BD52676FA; Tue, 8 Apr 2025 10:56:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744109768; cv=none; b=BdHbbkJBYD8JISsxs0yvqqpAQ16jP6z+73Bec0AF85cBHml632tTYikG9uchpH5HIl8JsrN8mCKhUMZ7IGezpsalPxjORSbqBNnqb91rWGCUJRa8jVoymt6Y2wJYn18+4mDsY08xsJSAt0t3wONkoxzMRcR/pmgp/+ge22l5cn0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744109768; c=relaxed/simple; bh=xb2DQAkImF+Nzk866o4Pi3XPwgXTTpSGFyWcy8dZoMw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ED0EmtFwDNDEK0WMwXDno6fcw5rhGpjS0GNp8b4FYw/SHlGe0uLfXvwUDTtryVrNX8KTWWL8sjyrNoF8l6GxGDaiFS9fBMU4saO0MUJ98YdQFvOMON7DOsGb4wIdxxTSCK40/s8RbdmAGVHsOktFhuZgIBiH1JSstuSddPJZPvw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=l7tYtfTG; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="l7tYtfTG" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A6050C4CEE5; Tue, 8 Apr 2025 10:56:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1744109768; bh=xb2DQAkImF+Nzk866o4Pi3XPwgXTTpSGFyWcy8dZoMw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=l7tYtfTGmqm6941Xc3Kym35mQB3/6GKMnKiskHzjuE9cnPAqV4ZEdmXG8B3gGLx0n iY0cWCdhyPD0xp/gOlM8r8dl8I+Cxwr4baHiwhQkXCF2aWVyYYaVgQjzrbXksj5eZL VPmMztGXJZwzZf6t/S2c0BnbNm+2sHNMh1GzmmcE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Artur Weber , Linus Walleij , Sasha Levin Subject: [PATCH 5.10 008/227] pinctrl: bcm281xx: Fix incorrect regmap max_registers value Date: Tue, 8 Apr 2025 12:46:26 +0200 Message-ID: <20250408104820.632216473@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250408104820.353768086@linuxfoundation.org> References: <20250408104820.353768086@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Artur Weber [ Upstream commit 68283c1cb573143c0b7515e93206f3503616bc10 ] The max_registers value does not take into consideration the stride; currently, it's set to the number of the last pin, but this does not accurately represent the final register. Fix this by multiplying the current value by 4. Fixes: 54b1aa5a5b16 ("ARM: pinctrl: Add Broadcom Capri pinctrl driver") Signed-off-by: Artur Weber Link: https://lore.kernel.org/20250207-bcm21664-pinctrl-v1-2-e7cfac9b2d3b@gmail.com Signed-off-by: Linus Walleij Signed-off-by: Sasha Levin --- drivers/pinctrl/bcm/pinctrl-bcm281xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/bcm/pinctrl-bcm281xx.c b/drivers/pinctrl/bcm/pinctrl-bcm281xx.c index 9ab1f427286a7..fbfddcc39d5cc 100644 --- a/drivers/pinctrl/bcm/pinctrl-bcm281xx.c +++ b/drivers/pinctrl/bcm/pinctrl-bcm281xx.c @@ -981,7 +981,7 @@ static const struct regmap_config bcm281xx_pinctrl_regmap_config = { .reg_bits = 32, .reg_stride = 4, .val_bits = 32, - .max_register = BCM281XX_PIN_VC_CAM3_SDA, + .max_register = BCM281XX_PIN_VC_CAM3_SDA * 4, }; static int bcm281xx_pinctrl_get_groups_count(struct pinctrl_dev *pctldev) -- 2.39.5