From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73B62268691; Tue, 8 Apr 2025 11:03:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744110227; cv=none; b=k1UWhtW1gKv3O6Q4sZ5yy4aZEcrn35WFqV/flwnq7tjIc678g3mSP7CIn+bYHFmPAm+DYdt8HAXrb7iwAraTChjYHhoLzqtcEtQfrtaGJtsmcOeQmYF9XNOoQ8+ZvNPtXrxK0SWx5eNKQ4Gv9YndqtY4A09HLwY53A7WrvQj4rU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744110227; c=relaxed/simple; bh=ufChVWYQ2nothh9FDw7HBoM8xaVTymRDszDalUJlNY8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tbsLPWF6pzShumAXHO/TPjR0YogZA80nu3b0Mtcg45o8O5zbjkbcmI7cSEYkgHxJBB7VQrixoS5Wsr393nJCrAsFH40LjHEpe8Z43m+O3pOjUcTHwH2zLmrwF2cwDAri7ZPtOkbV14um4jf8kfGjxkoZHFszrNsYG1tQgrlcsOA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ZuWagN4H; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ZuWagN4H" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8202FC4CEE7; Tue, 8 Apr 2025 11:03:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1744110226; bh=ufChVWYQ2nothh9FDw7HBoM8xaVTymRDszDalUJlNY8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZuWagN4HhS6ypqfAXv7Nde7PTuH6EST0xWNzagRhVzdN58E/U7qn4LaDR0iiJXyzj quWynhMspiE3QpjE9gUhvxIfCROBGW/8ZCXoPJAfZwEH8qJQyTCeq3te5to5RODXnz juFlM7mOgFbxrmFu3HGKuXI2uhYqdsboqIwd+Qks= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, kernel test robot , Josh Poimboeuf , Ingo Molnar , Mauro Carvalho Chehab , Linus Torvalds , Sasha Levin Subject: [PATCH 5.10 174/227] objtool, media: dib8000: Prevent divide-by-zero in dib8000_set_dds() Date: Tue, 8 Apr 2025 12:49:12 +0200 Message-ID: <20250408104825.534417238@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250408104820.353768086@linuxfoundation.org> References: <20250408104820.353768086@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Josh Poimboeuf [ Upstream commit e63d465f59011dede0a0f1d21718b59a64c3ff5c ] If dib8000_set_dds()'s call to dib8000_read32() returns zero, the result is a divide-by-zero. Prevent that from happening. Fixes the following warning with an UBSAN kernel: drivers/media/dvb-frontends/dib8000.o: warning: objtool: dib8000_tune() falls through to next function dib8096p_cfg_DibRx() Fixes: 173a64cb3fcf ("[media] dib8000: enhancement") Reported-by: kernel test robot Signed-off-by: Josh Poimboeuf Signed-off-by: Ingo Molnar Cc: Mauro Carvalho Chehab Cc: Linus Torvalds Link: https://lore.kernel.org/r/bd1d504d930ae3f073b1e071bcf62cae7708773c.1742852847.git.jpoimboe@kernel.org Closes: https://lore.kernel.org/r/202503210602.fvH5DO1i-lkp@intel.com/ Signed-off-by: Sasha Levin --- drivers/media/dvb-frontends/dib8000.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/media/dvb-frontends/dib8000.c b/drivers/media/dvb-frontends/dib8000.c index 02cb48223dc67..a28cbbd9e475c 100644 --- a/drivers/media/dvb-frontends/dib8000.c +++ b/drivers/media/dvb-frontends/dib8000.c @@ -2701,8 +2701,11 @@ static void dib8000_set_dds(struct dib8000_state *state, s32 offset_khz) u8 ratio; if (state->revision == 0x8090) { + u32 internal = dib8000_read32(state, 23) / 1000; + ratio = 4; - unit_khz_dds_val = (1<<26) / (dib8000_read32(state, 23) / 1000); + + unit_khz_dds_val = (1<<26) / (internal ?: 1); if (offset_khz < 0) dds = (1 << 26) - (abs_offset_khz * unit_khz_dds_val); else -- 2.39.5