From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CA642459E0; Tue, 29 Apr 2025 16:51:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745945503; cv=none; b=FmX3LqLVAlk5V+e+/wxXLwUUZfKG2/Om2dxEEK4LGyJnkFcoXqyYCO7Ewvm9/OBD8i8l6LtamFycUR8ZXLE0qvy+hPRclBacnY5nCht21dUnFrma6eYTbr3n47bdmFjArtb/yhInpYnQjRjwAMawig+bwqxKCXoNwdDTdbW0Blc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745945503; c=relaxed/simple; bh=uzKsuT+IZHO31RKpgLUXBLuQxFgmCLcpbRmiA3/1e64=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ZJQ25jg3bLvLUbN7L9s9UN1QQDpO9IS5Zouioijy7W37wf4/7DQsrB1cB0h2k98eO/+PYgi52+aT4i+NRol02tsp9ASr+1SsSYmxhfKrdUFJlx0it5cxtJOs09yAz7NPaSOn+mVAYkA3DgqtSUW80DKLEV059E5Pv+ar+Iogiv4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Wlt+hk9h; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Wlt+hk9h" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92EBAC4CEE3; Tue, 29 Apr 2025 16:51:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1745945502; bh=uzKsuT+IZHO31RKpgLUXBLuQxFgmCLcpbRmiA3/1e64=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Wlt+hk9h0Jx5d8c2mX/X2X/Te4P+3ON4lloyRC8OXil/hLw1ErHHqbPfhfNzMYdSl h2YECN9RhvGSd2qMpAeFPP3jGnIwx+nM0wPB6svdkI2k0PjMNlaBoZTHOjERjBlHRP RCu0jaWby7byisZuxaVxcVSBgQkfCYMJiG6GmG+E= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, =?UTF-8?q?Nuno=20S=C3=A1?= , Jonathan Cameron , Sasha Levin Subject: [PATCH 5.4 135/179] iio: adc: ad7768-1: Move setting of val a bit later to avoid unnecessary return value check Date: Tue, 29 Apr 2025 18:41:16 +0200 Message-ID: <20250429161054.859031071@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250429161049.383278312@linuxfoundation.org> References: <20250429161049.383278312@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jonathan Cameron [ Upstream commit 0af1c801a15225304a6328258efbf2bee245c654 ] The data used is all in local variables so there is no advantage in setting *val = ret with the direct mode claim held. Move it later to after error check. Reviewed-by: Nuno Sá Link: https://patch.msgid.link/20250217141630.897334-13-jic23@kernel.org Signed-off-by: Jonathan Cameron Stable-dep-of: 8236644f5ecb ("iio: adc: ad7768-1: Fix conversion result sign") Signed-off-by: Sasha Levin --- drivers/iio/adc/ad7768-1.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/iio/adc/ad7768-1.c b/drivers/iio/adc/ad7768-1.c index 9e26517870595..9b9956c0b076f 100644 --- a/drivers/iio/adc/ad7768-1.c +++ b/drivers/iio/adc/ad7768-1.c @@ -369,12 +369,11 @@ static int ad7768_read_raw(struct iio_dev *indio_dev, return ret; ret = ad7768_scan_direct(indio_dev); - if (ret >= 0) - *val = ret; iio_device_release_direct_mode(indio_dev); if (ret < 0) return ret; + *val = ret; return IIO_VAL_INT; -- 2.39.5