From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25FD221ABBD; Tue, 29 Apr 2025 18:09:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745950179; cv=none; b=sXt0gliu1RKOiZWlJl/ERzm2pYYUU0jA0/s6kzHD+Ahm65efP4JUpFUq7DJkg51PsLOFKoCnt6PO5IorMwG7qURudKDXRWZNPPPJYzWWI5x019Lnhmo0oTxuqi29xJWAdElZfgkog9GMuI+3zgMTnF/xlnawO1Okb7UMLuTmi9A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745950179; c=relaxed/simple; bh=R4e3cj8+3hqv5M0AONC95k9X9dJ3Ra5A519UqW8CNCM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WxqKzmo5nm4RIbYGb3ci37M96nluTPJYojpalPN4m6VVyjGNO2g8X8DUESIA3/yRQeLMupj6b0tZCofMUEfKYBem//siGbXovy+HcN6KinR9D6G4X98tVqh+c6b8zEOxbZUm4/4zEbuFa5beYlWJMGn2tphs0GJOIqG4acIKq6k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=OFzBrikU; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="OFzBrikU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7F8ABC4CEE3; Tue, 29 Apr 2025 18:09:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1745950179; bh=R4e3cj8+3hqv5M0AONC95k9X9dJ3Ra5A519UqW8CNCM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OFzBrikUAdOTfun7CMyJgEM/xQV0zn20UpXkun2dywelXMspO/7G9wbr9KQqynJ9V nZBBB5cAfGkGyGJqf/twCrQMDh3Y8OD/Dk2637Jtg30yho8QTioHVU+cBKk3SJ9av4 43X3U7uzvhY0itbhqsuMkNmQuvBeqUQx1dl3ZrOA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Tudor Ambarus , Krzysztof Kozlowski , Ulf Hansson , Abel Vesa , Manivannan Sadhasivam , Bjorn Andersson , Sasha Levin Subject: [PATCH 6.6 013/204] mmc: sdhci-msm: fix dev reference leaked through of_qcom_ice_get Date: Tue, 29 Apr 2025 18:41:41 +0200 Message-ID: <20250429161059.952193211@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250429161059.396852607@linuxfoundation.org> References: <20250429161059.396852607@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Tudor Ambarus [ Upstream commit cbef7442fba510b7eb229dcc9f39d3dde4a159a4 ] The driver leaks the device reference taken with of_find_device_by_node(). Fix the leak by using devm_of_qcom_ice_get(). Fixes: c7eed31e235c ("mmc: sdhci-msm: Switch to the new ICE API") Cc: stable@vger.kernel.org Signed-off-by: Tudor Ambarus Reviewed-by: Krzysztof Kozlowski Acked-by: Ulf Hansson Reviewed-by: Abel Vesa Reviewed-by: Manivannan Sadhasivam Link: https://lore.kernel.org/r/20250117-qcom-ice-fix-dev-leak-v2-2-1ffa5b6884cb@linaro.org Signed-off-by: Bjorn Andersson Signed-off-by: Sasha Levin --- drivers/mmc/host/sdhci-msm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c index 945d08531de37..82808cc373f68 100644 --- a/drivers/mmc/host/sdhci-msm.c +++ b/drivers/mmc/host/sdhci-msm.c @@ -1866,7 +1866,7 @@ static int sdhci_msm_ice_init(struct sdhci_msm_host *msm_host, if (!(cqhci_readl(cq_host, CQHCI_CAP) & CQHCI_CAP_CS)) return 0; - ice = of_qcom_ice_get(dev); + ice = devm_of_qcom_ice_get(dev); if (ice == ERR_PTR(-EOPNOTSUPP)) { dev_warn(dev, "Disabling inline encryption support\n"); ice = NULL; -- 2.39.5