From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0EC2254B0E; Tue, 29 Apr 2025 18:19:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745950760; cv=none; b=SAY/Mi+0FcIa0mt/rrCOQTT10U1VcjSc4qW/3YdmQOF0Iexgh2pzoAzL4T47JE1cdBPPaxSl5ZMxnQT8vmrRCMAYw7ZzbHQr6PHvvP/l7xO72AKZf4Epg4Vbcv5TAEtbUoHWzXFEHgu7+jVj9ehjscs4hGp6LUgG5WY1r6Dx6WM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745950760; c=relaxed/simple; bh=W1PSbjRX385k4I3J7TGdMZNsgQjIkOp52ZhvW+YgQBY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZyyLvklIh53l4+BHKTw57YQRjYxvQSS/epAppwMLbjaUC26wEJ47uH9cVSZWgkS5vkQElsxUsdxCNJFBObRHGM7nraO6OeCoccL0JcmNL0N5HaotfKegXU6TJnUAPsIWk837EPb36bb1emB7+/IzBofqTWSvbE8sNC01eaGexxo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=EEfJP9BS; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="EEfJP9BS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E3DCDC4CEE3; Tue, 29 Apr 2025 18:19:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1745950759; bh=W1PSbjRX385k4I3J7TGdMZNsgQjIkOp52ZhvW+YgQBY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EEfJP9BSPttqJK6LOk2OJEMUQxjtR83aDBYcWq8CLqheopsXXhStZsDIVi57HxrQb y5OLr8DW8Du55f/OgJgSsa87LfGVUdPWhocsHmf3VYzjIKUli/WKQGyHQH+YXra1JG HcTP/GYoLGjxMLeF976zCbcPHxwh2eIOR6ih2Uk8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yi Lai , Qiuxu Zhuo , Shuah Khan , Sasha Levin Subject: [PATCH 6.6 166/204] selftests/mincore: Allow read-ahead pages to reach the end of the file Date: Tue, 29 Apr 2025 18:44:14 +0200 Message-ID: <20250429161106.195509222@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250429161059.396852607@linuxfoundation.org> References: <20250429161059.396852607@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Qiuxu Zhuo [ Upstream commit 197c1eaa7ba633a482ed7588eea6fd4aa57e08d4 ] When running the mincore_selftest on a system with an XFS file system, it failed the "check_file_mmap" test case due to the read-ahead pages reaching the end of the file. The failure log is as below: RUN global.check_file_mmap ... mincore_selftest.c:264:check_file_mmap:Expected i (1024) < vec_size (1024) mincore_selftest.c:265:check_file_mmap:Read-ahead pages reached the end of the file check_file_mmap: Test failed FAIL global.check_file_mmap This is because the read-ahead window size of the XFS file system on this machine is 4 MB, which is larger than the size from the #PF address to the end of the file. As a result, all the pages for this file are populated. blockdev --getra /dev/nvme0n1p5 8192 blockdev --getbsz /dev/nvme0n1p5 512 This issue can be fixed by extending the current FILE_SIZE 4MB to a larger number, but it will still fail if the read-ahead window size of the file system is larger enough. Additionally, in the real world, read-ahead pages reaching the end of the file can happen and is an expected behavior. Therefore, allowing read-ahead pages to reach the end of the file is a better choice for the "check_file_mmap" test case. Link: https://lore.kernel.org/r/20250311080940.21413-1-qiuxu.zhuo@intel.com Reported-by: Yi Lai Signed-off-by: Qiuxu Zhuo Signed-off-by: Shuah Khan Signed-off-by: Sasha Levin --- tools/testing/selftests/mincore/mincore_selftest.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/tools/testing/selftests/mincore/mincore_selftest.c b/tools/testing/selftests/mincore/mincore_selftest.c index e949a43a61450..efabfcbe0b498 100644 --- a/tools/testing/selftests/mincore/mincore_selftest.c +++ b/tools/testing/selftests/mincore/mincore_selftest.c @@ -261,9 +261,6 @@ TEST(check_file_mmap) TH_LOG("No read-ahead pages found in memory"); } - EXPECT_LT(i, vec_size) { - TH_LOG("Read-ahead pages reached the end of the file"); - } /* * End of the readahead window. The rest of the pages shouldn't * be in memory. -- 2.39.5