From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABC601DF73C; Tue, 29 Apr 2025 17:10:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745946645; cv=none; b=L2+xq71H3WND0hiI+sg34v6jKdjl3wT3ANXIBjC+SDijyfpZhvD0Zj5aXSwOlFnOpzQNLWgsYtv74gjlhC1aNLS3Rv/jKOpK/QkvJtvs8R+gMyKt1DxJZ3ftw4XgmmJ4P/BnSibVBbbREMT5fztQ1nledlfMnVRbjdDVRIm2/EI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745946645; c=relaxed/simple; bh=V9r3EZXj0Ad7My14wqTbddHBRK4eQVmebbu3bWjFSO0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PzWcHeBqZa43v88TTWbu86InMIWHAWpPwV4m8G6BsnWVCCawi6wuw3wdSh8x5TDnC7OfpQZ9AmuBHZ0M+Esu7Jod/XB4DcpfRrw1C+CxcGO/0ZAyv8RRlW32ioBnDE91h2HDqw9lTk9RQ/zC/37BUej9rBIsnRCNT4rE8Z5r8Xs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=NB5yydu7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="NB5yydu7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7ADF8C4CEE3; Tue, 29 Apr 2025 17:10:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1745946645; bh=V9r3EZXj0Ad7My14wqTbddHBRK4eQVmebbu3bWjFSO0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NB5yydu7E7WowVuqIfWqs9z9QY3SLT1RCPiP4g14G7rbFltncNp4EB3LJ0nk6iDMs NJrVK4CWKieaJOOGjnjaUbaC93LqEJUzfS17mMTvmaGqe3FJ5QzO/R0yBPQQw8Uh7M cEuHgqzUr9cXPzh2U+9WQS4gZ6iRwa0H/KZccDq4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Rand Deeb , Dave Kleikamp , Sasha Levin Subject: [PATCH 5.10 022/286] fs/jfs: cast inactags to s64 to prevent potential overflow Date: Tue, 29 Apr 2025 18:38:46 +0200 Message-ID: <20250429161108.766221640@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250429161107.848008295@linuxfoundation.org> References: <20250429161107.848008295@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Rand Deeb [ Upstream commit 70ca3246ad201b53a9f09380b3f29d8bac320383 ] The expression "inactags << bmp->db_agl2size" in the function dbFinalizeBmap() is computed using int operands. Although the values (inactags and db_agl2size) are derived from filesystem parameters and are usually small, there is a theoretical risk that the shift could overflow a 32-bit int if extreme values occur. According to the C standard, shifting a signed 32-bit int can lead to undefined behavior if the result exceeds its range. In our case, an overflow could miscalculate free blocks, potentially leading to erroneous filesystem accounting. To ensure the arithmetic is performed in 64-bit space, we cast "inactags" to s64 before shifting. This defensive fix prevents any risk of overflow and complies with kernel coding best practices. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Rand Deeb Signed-off-by: Dave Kleikamp Signed-off-by: Sasha Levin --- fs/jfs/jfs_dmap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/jfs/jfs_dmap.c b/fs/jfs/jfs_dmap.c index ef220709c7f51..389dafd23d15e 100644 --- a/fs/jfs/jfs_dmap.c +++ b/fs/jfs/jfs_dmap.c @@ -3728,8 +3728,8 @@ void dbFinalizeBmap(struct inode *ipbmap) * system size is not a multiple of the group size). */ inactfree = (inactags && ag_rem) ? - ((inactags - 1) << bmp->db_agl2size) + ag_rem - : inactags << bmp->db_agl2size; + (((s64)inactags - 1) << bmp->db_agl2size) + ag_rem + : ((s64)inactags << bmp->db_agl2size); /* determine how many free blocks are in the active * allocation groups plus the average number of free blocks -- 2.39.5