From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53291243364; Tue, 29 Apr 2025 17:12:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745946747; cv=none; b=jheHaQgOwWRSLZclkY6wnnYpbso8QrH7BK/MmV67KMYOnSZHlREzeCRbP1cFO+EmXbxRylrTpSqD2Ggoq6ChpRnir7Y+ujh0klMSQICVKkpcaFCfBrU+vIdR3XrIRib4FQyXHTkdDeqQFzUUpFqnpqNCfSWDAWJon00lIvwBAeA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745946747; c=relaxed/simple; bh=f9fVBb8PYMXCTBQw4xOpd8MmfSoEBwLpXDyOKmM6K9M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dZzmeohYd8XHQtlFjSECwzC5O9itRUHOT1XUBYzDKgZjHb3yicEUsM6R5n9IwErLdeCr30mnia9mdvniE9NDeJhdvqtCLE31H0wMEJrUDzRIzNEGIQrccIRJBYUC9jI9ybu92WU0wWlButDvbCiR+BZx+FuIcxmD7Inr2/VqLhU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=oXXyLEN5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="oXXyLEN5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C4067C4CEE3; Tue, 29 Apr 2025 17:12:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1745946747; bh=f9fVBb8PYMXCTBQw4xOpd8MmfSoEBwLpXDyOKmM6K9M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oXXyLEN5a/zRM1EnwY8dywuEQnqBYRWQFHX8SsTRAzpxCbbJbh9Zk8BN2/Ga9szXu XA2kcGL1SG+YcczBN73V3X2pkfoqJn4qtwQn/IAGp9MVGVznH2YN0xT+WgZN0O/SWk xU2eKXU9G/wO7D2ShqXK+gZ1RO24ufWtpYmVWafk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Matthew Majewski , Hans Verkuil Subject: [PATCH 5.10 056/286] media: vim2m: print device name after registering device Date: Tue, 29 Apr 2025 18:39:20 +0200 Message-ID: <20250429161110.153446718@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250429161107.848008295@linuxfoundation.org> References: <20250429161107.848008295@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Matthew Majewski commit 143d75583f2427f3a97dba62413c4f0604867ebf upstream. Move the v4l2_info() call displaying the video device name after the device is actually registered. This fixes a bug where the driver was always displaying "/dev/video0" since it was reading from the vfd before it was registered. Fixes: cf7f34777a5b ("media: vim2m: Register video device after setting up internals") Cc: stable@vger.kernel.org Signed-off-by: Matthew Majewski Signed-off-by: Hans Verkuil Signed-off-by: Greg Kroah-Hartman --- drivers/media/test-drivers/vim2m.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- a/drivers/media/test-drivers/vim2m.c +++ b/drivers/media/test-drivers/vim2m.c @@ -1326,9 +1326,6 @@ static int vim2m_probe(struct platform_d vfd->v4l2_dev = &dev->v4l2_dev; video_set_drvdata(vfd, dev); - v4l2_info(&dev->v4l2_dev, - "Device registered as /dev/video%d\n", vfd->num); - platform_set_drvdata(pdev, dev); dev->m2m_dev = v4l2_m2m_init(&m2m_ops); @@ -1355,6 +1352,9 @@ static int vim2m_probe(struct platform_d goto error_m2m; } + v4l2_info(&dev->v4l2_dev, + "Device registered as /dev/video%d\n", vfd->num); + #ifdef CONFIG_MEDIA_CONTROLLER ret = v4l2_m2m_register_media_controller(dev->m2m_dev, vfd, MEDIA_ENT_F_PROC_VIDEO_SCALER);