From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A47AE25228D; Tue, 29 Apr 2025 17:15:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745946936; cv=none; b=HvI8RfAXOsxee6/A/OolNVpoXhn1+IUtOTp2r382/uHS5TJQqGDQc6PjgqYdZ5JNaHSn8m0daELP+tsNQSWcl36FPTVlcPQ9t6BcWZIfiovlbPev1ESWQLQdj4DvbpMq19wFIK5VpwmZHpIERwUf+MThRk3YU29Dv+naXtRS8eM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745946936; c=relaxed/simple; bh=ApYR7iKvJq/7behGoaG/ZfGA1x+R+wr1S29MmBxoKSY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gjUKTkLDFj46UsCCPIc7OrcDSkmDeYfH1i5vY/+UUCgvIVxgUn/FjwxmsHEMJohxbAxGwfD2Hcxzo6WpCf9CULjtaxb6U+vKPKNS91Tc9MJZuTZgk84NlP6Ms8Q4FLUYcCTZ20oQyP45MvStiGF8UJTt1HQqcu7pjdIye7vrufA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=FHl1JFhG; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="FHl1JFhG" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2CC24C4CEE3; Tue, 29 Apr 2025 17:15:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1745946936; bh=ApYR7iKvJq/7behGoaG/ZfGA1x+R+wr1S29MmBxoKSY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FHl1JFhGIBZoMFA04jjc+a0MDnVboj2Df06zEKG52AR/k6qT6nc3BmEuc+6sByiBB QgVkOkQLkYwfvvAA2KoMaLVxtzVu6DtvtJt2pcGVoZsWOSVpcmUZz5lCYt7oqSALnz dFzHnAICLvFo8JAfiFir4QmhooUrwHq0XOjf9DOo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jonas Gorski , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.10 117/286] net: b53: enable BPDU reception for management port Date: Tue, 29 Apr 2025 18:40:21 +0200 Message-ID: <20250429161112.669200669@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250429161107.848008295@linuxfoundation.org> References: <20250429161107.848008295@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jonas Gorski [ Upstream commit 36355ddfe8955f226a88a543ed354b9f6b84cd70 ] For STP to work, receiving BPDUs is essential, but the appropriate bit was never set. Without GC_RX_BPDU_EN, the switch chip will filter all BPDUs, even if an appropriate PVID VLAN was setup. Fixes: ff39c2d68679 ("net: dsa: b53: Add bridge support") Signed-off-by: Jonas Gorski Link: https://patch.msgid.link/20250414200434.194422-1-jonas.gorski@gmail.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/dsa/b53/b53_common.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_common.c index 2fc33019e814a..d3428e62bef24 100644 --- a/drivers/net/dsa/b53/b53_common.c +++ b/drivers/net/dsa/b53/b53_common.c @@ -686,6 +686,15 @@ static void b53_enable_mib(struct b53_device *dev) b53_write8(dev, B53_MGMT_PAGE, B53_GLOBAL_CONFIG, gc); } +static void b53_enable_stp(struct b53_device *dev) +{ + u8 gc; + + b53_read8(dev, B53_MGMT_PAGE, B53_GLOBAL_CONFIG, &gc); + gc |= GC_RX_BPDU_EN; + b53_write8(dev, B53_MGMT_PAGE, B53_GLOBAL_CONFIG, gc); +} + static u16 b53_default_pvid(struct b53_device *dev) { if (is5325(dev) || is5365(dev)) @@ -807,6 +816,7 @@ static int b53_switch_reset(struct b53_device *dev) } b53_enable_mib(dev); + b53_enable_stp(dev); return b53_flush_arl(dev, FAST_AGE_STATIC); } -- 2.39.5