From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A37D23F405; Tue, 29 Apr 2025 17:17:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745947063; cv=none; b=OPY+CoH7yvmNy374WhgrsQXbb3978F4Ht5c6DkKrtJI+XiRDcGzwBchbjnxzcF0QU4RXp8+SLsJ3/hIUsqUbSDLm7mDvR9HQhDJmddyaP2FzVuY3lefDxOXIqLyVhIH/3hnbPNhm6p23P9u+TgW/Iw3iJkP3hwNhcWiiKQGzwUI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745947063; c=relaxed/simple; bh=JG0lGrz+i2oFMSkEiiFlbEjA08gJi83v8KWmGI/f9So=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nmB1IKLzK+WkbSAugKFXxmGQPbNw4R2589cdNfWD6LxioCq/jmVhD/5aSLGwTW9YwiPW5qSARbI+zi56+WUU9rbagREV019gJl4q9msupBOg7c/HF4iExyplbP8nnBZngGAMwrGmZlAbeZyMtraMnnJjvGtA7WB9geiJJTftWXk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=xtZ74xOC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="xtZ74xOC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0EDA5C4CEE3; Tue, 29 Apr 2025 17:17:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1745947063; bh=JG0lGrz+i2oFMSkEiiFlbEjA08gJi83v8KWmGI/f9So=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xtZ74xOCeSzIWzSSwFl1P9wfHXMwWYLnp0MAH6iGI0m10gYvm0w7c8SKQYS/iBJYr ZO4kcY2QVW0zCLeVenaS6b5GrTDB1SlDDxIYROQxI/je2IUd7lTUGdL0+F4huLqE8i 2VrSjC9kNmP0rB2lEYN3VTpRqvgYPJKvvVXuL6mE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Masami Hiramatsu , Mathieu Desnoyers , Andrew Morton , Andrii Nakryiko , Mykyta Yatsenko , "Steven Rostedt (Google)" Subject: [PATCH 5.10 132/286] tracing: Fix filter string testing Date: Tue, 29 Apr 2025 18:40:36 +0200 Message-ID: <20250429161113.298794695@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250429161107.848008295@linuxfoundation.org> References: <20250429161107.848008295@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Steven Rostedt commit a8c5b0ed89a3f2c81c6ae0b041394e6eea0e7024 upstream. The filter string testing uses strncpy_from_kernel/user_nofault() to retrieve the string to test the filter against. The if() statement was incorrect as it considered 0 as a fault, when it is only negative that it faulted. Running the following commands: # cd /sys/kernel/tracing # echo "filename.ustring ~ \"/proc*\"" > events/syscalls/sys_enter_openat/filter # echo 1 > events/syscalls/sys_enter_openat/enable # ls /proc/$$/maps # cat trace Would produce nothing, but with the fix it will produce something like: ls-1192 [007] ..... 8169.828333: sys_openat(dfd: ffffffffffffff9c, filename: 7efc18359904, flags: 80000, mode: 0) Link: https://lore.kernel.org/all/CAEf4BzbVPQ=BjWztmEwBPRKHUwNfKBkS3kce-Rzka6zvbQeVpg@mail.gmail.com/ Cc: stable@vger.kernel.org Cc: Masami Hiramatsu Cc: Mathieu Desnoyers Cc: Andrew Morton Link: https://lore.kernel.org/20250417183003.505835fb@gandalf.local.home Fixes: 77360f9bbc7e5 ("tracing: Add test for user space strings when filtering on string pointers") Reported-by: Andrii Nakryiko Reported-by: Mykyta Yatsenko Signed-off-by: Steven Rostedt (Google) Signed-off-by: Greg Kroah-Hartman --- kernel/trace/trace_events_filter.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/kernel/trace/trace_events_filter.c +++ b/kernel/trace/trace_events_filter.c @@ -676,7 +676,7 @@ static __always_inline char *test_string kstr = ubuf->buffer; /* For safety, do not trust the string pointer */ - if (!strncpy_from_kernel_nofault(kstr, str, USTRING_BUF_SIZE)) + if (strncpy_from_kernel_nofault(kstr, str, USTRING_BUF_SIZE) < 0) return NULL; return kstr; } @@ -695,7 +695,7 @@ static __always_inline char *test_ustrin /* user space address? */ ustr = (char __user *)str; - if (!strncpy_from_user_nofault(kstr, ustr, USTRING_BUF_SIZE)) + if (strncpy_from_user_nofault(kstr, ustr, USTRING_BUF_SIZE) < 0) return NULL; return kstr;