From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E434E248878; Tue, 29 Apr 2025 17:19:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745947191; cv=none; b=SYWNWx2wPPAVziLGIa/Fa5SF00lqjRFkdKNb/A+OVfHg6Tci2xb21RM5bFFLhL4pNK98kAir/ey53UQkYPARR74YEi7H2nGFuloQgySMp7DzZBBR2tVv5IhLWKaiudrSFt+UmxN7xR9ABLmiNYooxAjzSwlySUotAAl71ORT+hw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745947191; c=relaxed/simple; bh=fkQgLUQ0LPMu0O5QzZtjbz6BTDUdX4YCvRBM2Iv1b6E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=iEOYjSgszDiPmxiu2D3FTMFDUE9lbNMdRmZMeE6ufIUkHxH8n0qV2fDv+R0nc1JU7L4QhH53NXY/DnUGEQKZzHrVAmVkPv0LdM2afcOeZ0JbYbViCdhWo42Wj1LbpNvye004HVGw+uujijeZh1MmQrZkBoggVsNMGMh1etYiOWw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=KcAwoPPr; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="KcAwoPPr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 54B3FC4CEEE; Tue, 29 Apr 2025 17:19:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1745947190; bh=fkQgLUQ0LPMu0O5QzZtjbz6BTDUdX4YCvRBM2Iv1b6E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KcAwoPPrumzHRzZqkiKsP18Axv3V1IOakVllO9Eaa+3PjGe53R06T8k2J/5hQO89A pDksd4/Rh9wqZojHZIuhsKD+wQmqLPULIKpPC5lizcbQRXAESS/rspR/G7P8y98YM0 47rUS9tHnp3uwTfnVtTvrpz+zIDLMrJZTYMy55Fw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Srinivas Pandruvada , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Sasha Levin Subject: [PATCH 5.10 194/286] platform/x86: ISST: Correct command storage data length Date: Tue, 29 Apr 2025 18:41:38 +0200 Message-ID: <20250429161115.946420757@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250429161107.848008295@linuxfoundation.org> References: <20250429161107.848008295@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Srinivas Pandruvada [ Upstream commit 9462e74c5c983cce34019bfb27f734552bebe59f ] After resume/online turbo limit ratio (TRL) is restored partially if the admin explicitly changed TRL from user space. A hash table is used to store SST mail box and MSR settings when modified to restore those settings after resume or online. This uses a struct isst_cmd field "data" to store these settings. This is a 64 bit field. But isst_store_new_cmd() is only assigning as u32. This results in truncation of 32 bits. Change the argument to u64 from u32. Fixes: f607874f35cb ("platform/x86: ISST: Restore state on resume") Signed-off-by: Srinivas Pandruvada Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20250328224749.2691272-1-srinivas.pandruvada@linux.intel.com Reviewed-by: Ilpo Järvinen Signed-off-by: Ilpo Järvinen Signed-off-by: Sasha Levin --- drivers/platform/x86/intel_speed_select_if/isst_if_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/intel_speed_select_if/isst_if_common.c b/drivers/platform/x86/intel_speed_select_if/isst_if_common.c index 407afafc7e83f..e0f7368e7e3e9 100644 --- a/drivers/platform/x86/intel_speed_select_if/isst_if_common.c +++ b/drivers/platform/x86/intel_speed_select_if/isst_if_common.c @@ -77,7 +77,7 @@ static DECLARE_HASHTABLE(isst_hash, 8); static DEFINE_MUTEX(isst_hash_lock); static int isst_store_new_cmd(int cmd, u32 cpu, int mbox_cmd_type, u32 param, - u32 data) + u64 data) { struct isst_cmd *sst_cmd; -- 2.39.5