From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED4C0254864; Tue, 29 Apr 2025 17:23:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745947410; cv=none; b=NgdG/daXufy3sGxffyHN1xUsd9v5uGBoCdGI/tvIAL4F03saYveHXWeLy6H5pb5P12K5zLo1UPiYUN4l851b3jYrjd+x9F9I3zTSoDUK4QMGBBLhO06phf+m1uX41dsm/IzBOTOk4r14XdvmAX/S5iY6WR2BU0bDzviMG/AbfbY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745947410; c=relaxed/simple; bh=xB45AOdmJhZAE9j3gxMUK1+2rET4UjF9zTUhYZMZnDE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=B20yyu9U7v9ozbM2DZlnSGTkCQBCs01gUsiz2XwOn+cp3q4TVXpL7yVfUAIngpS/r/uCcwYDF9Xa3B4PJ3wU0RCtEvp6TQTWGTq8+3tmlZUlDZjunIt8Zlanyap5JuWDf6jE+rcj8+dD1d7zWQ46YUP8AX735VTpDeDFcOb+LhE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=jagg/5Fn; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="jagg/5Fn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 451C3C4CEE3; Tue, 29 Apr 2025 17:23:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1745947409; bh=xB45AOdmJhZAE9j3gxMUK1+2rET4UjF9zTUhYZMZnDE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jagg/5FnUyuzUYD3k7lj+i0Za744tI6UgtXzjpRYYaHG5TOrDyw0jVGhSHM43katX 7A4I7ebSZj+jf7fpDLUbw9gCObSwqDkG6iAYTIhErdmex0n8TgSsJFn1VIaYXHf6DS hGXzXSMZVk2aIVuXMPJz0D78nhGXbuRabPIs5ZSA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Josh Poimboeuf , Ingo Molnar , Sasha Levin Subject: [PATCH 5.10 272/286] x86/bugs: Use SBPB in write_ibpb() if applicable Date: Tue, 29 Apr 2025 18:42:56 +0200 Message-ID: <20250429161119.109213010@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250429161107.848008295@linuxfoundation.org> References: <20250429161107.848008295@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Josh Poimboeuf [ Upstream commit fc9fd3f98423367c79e0bd85a9515df26dc1b3cc ] write_ibpb() does IBPB, which (among other things) flushes branch type predictions on AMD. If the CPU has SRSO_NO, or if the SRSO mitigation has been disabled, branch type flushing isn't needed, in which case the lighter-weight SBPB can be used. The 'x86_pred_cmd' variable already keeps track of whether IBPB or SBPB should be used. Use that instead of hardcoding IBPB. Signed-off-by: Josh Poimboeuf Signed-off-by: Ingo Molnar Link: https://lore.kernel.org/r/17c5dcd14b29199b75199d67ff7758de9d9a4928.1744148254.git.jpoimboe@kernel.org Signed-off-by: Sasha Levin --- arch/x86/entry/entry.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/entry/entry.S b/arch/x86/entry/entry.S index f4419afc7147d..bda217961172b 100644 --- a/arch/x86/entry/entry.S +++ b/arch/x86/entry/entry.S @@ -16,7 +16,7 @@ SYM_FUNC_START(entry_ibpb) movl $MSR_IA32_PRED_CMD, %ecx - movl $PRED_CMD_IBPB, %eax + movl _ASM_RIP(x86_pred_cmd), %eax xorl %edx, %edx wrmsr -- 2.39.5