From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A12B9224AE6; Tue, 29 Apr 2025 17:23:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745947416; cv=none; b=MbP3R1plGHWFwpbiuKORD4y8if0RE1adHScytSuEteLggjCPBYDps3btE2NTtWa0EwNNEsQgTQt4P4rott42crjlPSL1O7D2UZnA/758e8tNniR5WZiDGNYiYQtdN7J9sXrpE0q27LKancsn8DcJFhgr07pP/qxVRKLwZV+PUkw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745947416; c=relaxed/simple; bh=4iLCmCD8C+v5KEd4io0H4a6NDR/c+WgzkO//1GT/5So=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Bay09axDOrSuhsbvwtOd+8A0Vikc9w86fKogEEzQ2LYiv8tWH15aASgZfk1XDHt8R/JiYtseFZe1SVRd5plxBxWcDP7C90It5VynnnVdMCHsgs03othtWoqE8wvr/rgXEyPZCaNBGZgtXu+/w3JpPYfYcC9njfuu2NYF4CShG3M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=zsgfmaAD; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="zsgfmaAD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B307BC4CEE3; Tue, 29 Apr 2025 17:23:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1745947416; bh=4iLCmCD8C+v5KEd4io0H4a6NDR/c+WgzkO//1GT/5So=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zsgfmaADMm1WxDIGsDuwzTg+AfwOA0Smg0Dgm3AOW2LeFLm57EC6RtuoZpJoMEHeY kQ66azqERETiFB2W9bVA1Gzb8KHCToVH+fvw+l8dIU1Jg6Byoh7m/jFDAI5rK7yG2L ND/SYMZdTFWiySUPg4qMlYzkTLkpz2n4bNv5hpKw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Baokun Li , Jan Kara , Zhang Yi , Ojaswin Mujoo , Theodore Tso , Sasha Levin Subject: [PATCH 5.10 274/286] ext4: make block validity check resistent to sb bh corruption Date: Tue, 29 Apr 2025 18:42:58 +0200 Message-ID: <20250429161119.190695374@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250429161107.848008295@linuxfoundation.org> References: <20250429161107.848008295@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ojaswin Mujoo [ Upstream commit ccad447a3d331a239477c281533bacb585b54a98 ] Block validity checks need to be skipped in case they are called for journal blocks since they are part of system's protected zone. Currently, this is done by checking inode->ino against sbi->s_es->s_journal_inum, which is a direct read from the ext4 sb buffer head. If someone modifies this underneath us then the s_journal_inum field might get corrupted. To prevent against this, change the check to directly compare the inode with journal->j_inode. **Slight change in behavior**: During journal init path, check_block_validity etc might be called for journal inode when sbi->s_journal is not set yet. In this case we now proceed with ext4_inode_block_valid() instead of returning early. Since systems zones have not been set yet, it is okay to proceed so we can perform basic checks on the blocks. Suggested-by: Baokun Li Reviewed-by: Baokun Li Reviewed-by: Jan Kara Reviewed-by: Zhang Yi Signed-off-by: Ojaswin Mujoo Link: https://patch.msgid.link/0c06bc9ebfcd6ccfed84a36e79147bf45ff5adc1.1743142920.git.ojaswin@linux.ibm.com Signed-off-by: Theodore Ts'o Signed-off-by: Sasha Levin --- fs/ext4/block_validity.c | 5 ++--- fs/ext4/inode.c | 7 ++++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/fs/ext4/block_validity.c b/fs/ext4/block_validity.c index 295e89d93295e..5d5befac5622b 100644 --- a/fs/ext4/block_validity.c +++ b/fs/ext4/block_validity.c @@ -353,10 +353,9 @@ int ext4_check_blockref(const char *function, unsigned int line, { __le32 *bref = p; unsigned int blk; + journal_t *journal = EXT4_SB(inode->i_sb)->s_journal; - if (ext4_has_feature_journal(inode->i_sb) && - (inode->i_ino == - le32_to_cpu(EXT4_SB(inode->i_sb)->s_es->s_journal_inum))) + if (journal && inode == journal->j_inode) return 0; while (bref < p+max) { diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index 52d68edb6a09b..15d020279d3bd 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -409,10 +409,11 @@ static int __check_block_validity(struct inode *inode, const char *func, unsigned int line, struct ext4_map_blocks *map) { - if (ext4_has_feature_journal(inode->i_sb) && - (inode->i_ino == - le32_to_cpu(EXT4_SB(inode->i_sb)->s_es->s_journal_inum))) + journal_t *journal = EXT4_SB(inode->i_sb)->s_journal; + + if (journal && inode == journal->j_inode) return 0; + if (!ext4_inode_block_valid(inode, map->m_pblk, map->m_len)) { ext4_error_inode(inode, func, line, map->m_pblk, "lblock %lu mapped to illegal pblock %llu " -- 2.39.5