From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F078B24EF7F; Tue, 29 Apr 2025 16:56:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745945812; cv=none; b=mGJBYOwG/ccVBI1BZN3Hg0zOD3iG8JATbaRhbvjMUh57cFqSdMLcQC45ZFgQ4uIXqomIddmkv10HocqmUNI0S5fqlHiSExB7n55kd5H+xOgcjZNeS2EGrIPafdgH+/Ve59H1+VIHjbkZAqaXTKJf3ItVPlkz8S86Pp1a0ad9I3Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745945812; c=relaxed/simple; bh=f+j6EOSj72I4csUUebg1Ir/Oh2wR4Zh6O73OTPB9uEU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IEfYqQ6hE6r5U4OiLA2SChl2/Ko46RYOJTH9kSqD3rWYJvCAwEKBfx7r1n+6vsB3VqG2isIIxlHKN9Volzf3KcPbW4EfqzMvWqS/gEou7m2goDoEUYUR+uDVy2LKJwNiNZ2FBQfMulELNrhTqT4Uen5/rPvpFFi0rWCJZi+gTjw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=GonFUQI2; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="GonFUQI2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 82A8CC4CEE3; Tue, 29 Apr 2025 16:56:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1745945811; bh=f+j6EOSj72I4csUUebg1Ir/Oh2wR4Zh6O73OTPB9uEU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GonFUQI2sVeMgOSTCysC24kByrE3qvyVjqej7zTHGLdN1wscmaRakPao6Cn8UxJSX scKLQIhSZNx9e9mxXD2qLlpr7iYWvds50MZcDhD1j3fuRcDSvq/K+nk6eK1BkQ92cw A0djKJypccQhIUDMTFVYf7mQxiJLEC58/fpgfpq0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Tudor Ambarus , Krzysztof Kozlowski , Abel Vesa , Manivannan Sadhasivam , Bjorn Andersson , Sasha Levin , "Martin K. Petersen" Subject: [PATCH 6.14 018/311] scsi: ufs: qcom: fix dev reference leaked through of_qcom_ice_get Date: Tue, 29 Apr 2025 18:37:35 +0200 Message-ID: <20250429161121.779623153@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250429161121.011111832@linuxfoundation.org> References: <20250429161121.011111832@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Tudor Ambarus [ Upstream commit ded40f32b55f7f2f4ed9627dd3c37a1fe89ed8c6 ] The driver leaks the device reference taken with of_find_device_by_node(). Fix the leak by using devm_of_qcom_ice_get(). Fixes: 56541c7c4468 ("scsi: ufs: ufs-qcom: Switch to the new ICE API") Cc: stable@vger.kernel.org Signed-off-by: Tudor Ambarus Reviewed-by: Krzysztof Kozlowski Reviewed-by: Abel Vesa Acked-by: Martin K. Petersen # SCSI Reviewed-by: Manivannan Sadhasivam Link: https://lore.kernel.org/r/20250117-qcom-ice-fix-dev-leak-v2-3-1ffa5b6884cb@linaro.org Signed-off-by: Bjorn Andersson Signed-off-by: Sasha Levin --- drivers/ufs/host/ufs-qcom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c index 23b9f6efa0475..a455a95f65fc6 100644 --- a/drivers/ufs/host/ufs-qcom.c +++ b/drivers/ufs/host/ufs-qcom.c @@ -125,7 +125,7 @@ static int ufs_qcom_ice_init(struct ufs_qcom_host *host) int err; int i; - ice = of_qcom_ice_get(dev); + ice = devm_of_qcom_ice_get(dev); if (ice == ERR_PTR(-EOPNOTSUPP)) { dev_warn(dev, "Disabling inline encryption support\n"); ice = NULL; -- 2.39.5