From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E48431FE468; Tue, 29 Apr 2025 17:04:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745946296; cv=none; b=OYMTvs04OTi9xAlrhlIOBFEVNg2wksaEG9lmYb+9ATIRp6WR26UIee+xGvcrRDnzYxLKKedxoNJ4voHmEMTonEqCVieUDG9vWEJEfUmqUyJMQBiD+wnqnbzbMbZmXS2YHeKjvTAP1Ib3ykbOyKOmYcBAulzh8mCoTu/HWKolIIs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745946296; c=relaxed/simple; bh=PBIogwSgEm6mXvDBIdArn+Gw3It6q1MPL3rtvFv2x/U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lU3hcVSrKI9ptyVcxkZtNWLVaqBYs4xqXx9aFJhYIAqF4P+rtvJiKPvkyzHE537yg410VBtKb74z8+246prjMjvPsBLdAwql+o1KB9F7v6M1L4GbeyLTlKfJMdC392DuvSZEqd3U30adA820YIPJBga79pMZryWKV1VSupPYE10= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=UH+8jUAu; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="UH+8jUAu" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CE774C4CEE3; Tue, 29 Apr 2025 17:04:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1745946295; bh=PBIogwSgEm6mXvDBIdArn+Gw3It6q1MPL3rtvFv2x/U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UH+8jUAuwhqY5/fIsMzH9H9OcnbdEhWSBm54lGEZeWaAHvSD6UVbJA10vVKMhXijd eUm2l4TvWspgIy1pZWskhI6t32/j8GMfFIsm4ehwvJ/xRE/EqgEV3vm9q+2rYrqsl+ DRWMRt4WuMTuQXboa6Gb06olojRtPK647jDs+A3M= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Haoxiang Li , Heiko Carstens , Vasily Gorbik , Sasha Levin Subject: [PATCH 6.14 189/311] s390/sclp: Add check for get_zeroed_page() Date: Tue, 29 Apr 2025 18:40:26 +0200 Message-ID: <20250429161128.758132733@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250429161121.011111832@linuxfoundation.org> References: <20250429161121.011111832@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Haoxiang Li [ Upstream commit 3db42c75a921854a99db0a2775814fef97415bac ] Add check for the return value of get_zeroed_page() in sclp_console_init() to prevent null pointer dereference. Furthermore, to solve the memory leak caused by the loop allocation, add a free helper to do the free job. Signed-off-by: Haoxiang Li Acked-by: Heiko Carstens Link: https://lore.kernel.org/r/20250218025216.2421548-1-haoxiang_li2024@163.com Signed-off-by: Vasily Gorbik Signed-off-by: Sasha Levin --- drivers/s390/char/sclp_con.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/drivers/s390/char/sclp_con.c b/drivers/s390/char/sclp_con.c index e5d947c763ea5..6a030ba38bf36 100644 --- a/drivers/s390/char/sclp_con.c +++ b/drivers/s390/char/sclp_con.c @@ -263,6 +263,19 @@ static struct console sclp_console = .index = 0 /* ttyS0 */ }; +/* + * Release allocated pages. + */ +static void __init __sclp_console_free_pages(void) +{ + struct list_head *page, *p; + + list_for_each_safe(page, p, &sclp_con_pages) { + list_del(page); + free_page((unsigned long)page); + } +} + /* * called by console_init() in drivers/char/tty_io.c at boot-time. */ @@ -282,6 +295,10 @@ sclp_console_init(void) /* Allocate pages for output buffering */ for (i = 0; i < sclp_console_pages; i++) { page = (void *) get_zeroed_page(GFP_KERNEL | GFP_DMA); + if (!page) { + __sclp_console_free_pages(); + return -ENOMEM; + } list_add_tail(page, &sclp_con_pages); } sclp_conbuf = NULL; -- 2.39.5