From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DE25215060; Tue, 29 Apr 2025 17:56:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745949388; cv=none; b=Fr2gS+sZ5t8xYsQskr8lTAMJ36kyINE2SJYbtBD+NJStXX2CwySgvyU41O0v4ylCjUcmEErwIt5gnAjLLgmfjl/VknF8TT7aeS2+F6WqpNYMmYM3vVPAz7kS4PTIrucfFKxvZDSlOHuWd034TgkgKo0lzo7IZNmXKN6WC1VHi9k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745949388; c=relaxed/simple; bh=5/lmN5WwrLAmqMXqjWPR/p+hPLX8YfDcIHOJrPS1oXg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UAPXUzdeNCPYBQqLDCJwR0tn+a4nZ6WOuuN2rJCQBQYVcj1V/iP1cMyzblij67E1phjdAUpNENmOAB4xYK9VfsTQ44zThRefZbbEYBon3g7ezFRcgjnsHKhXBr7J+oNuN8cfwkxunHXtMYPU2to/VkIIqDDC6Z6GUkiLlvBRklQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=f2n3/Z5T; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="f2n3/Z5T" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5A4FEC4CEE3; Tue, 29 Apr 2025 17:56:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1745949387; bh=5/lmN5WwrLAmqMXqjWPR/p+hPLX8YfDcIHOJrPS1oXg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=f2n3/Z5TRxSN8TTHLPBHTl/krUQCgyqfPouv7gDn3BVCrDjTXgYsHVLlhZ0tCLZuC Xmi+NHpYsgswjg/JY/bYPTqKPxySDAZKyY93iNGRRRB+lhUFfgdcdwtRP3SwoQLxaz w3DLjbJ6tw9tsbfUqMGHE/Bl7SoJKiygEjnJo8e0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable , Haoxiang Li , Johannes Thumshirn Subject: [PATCH 5.15 302/373] mcb: fix a double free bug in chameleon_parse_gdd() Date: Tue, 29 Apr 2025 18:42:59 +0200 Message-ID: <20250429161135.536197386@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250429161123.119104857@linuxfoundation.org> References: <20250429161123.119104857@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Haoxiang Li commit 7c7f1bfdb2249f854a736d9b79778c7e5a29a150 upstream. In chameleon_parse_gdd(), if mcb_device_register() fails, 'mdev' would be released in mcb_device_register() via put_device(). Thus, goto 'err' label and free 'mdev' again causes a double free. Just return if mcb_device_register() fails. Fixes: 3764e82e5150 ("drivers: Introduce MEN Chameleon Bus") Cc: stable Signed-off-by: Haoxiang Li Signed-off-by: Johannes Thumshirn Link: https://lore.kernel.org/r/6201d09e2975ae5789879f79a6de4c38de9edd4a.1741596225.git.jth@kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/mcb/mcb-parse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/mcb/mcb-parse.c +++ b/drivers/mcb/mcb-parse.c @@ -101,7 +101,7 @@ static int chameleon_parse_gdd(struct mc ret = mcb_device_register(bus, mdev); if (ret < 0) - goto err; + return ret; return 0;