From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69ECA19AD5C; Wed, 7 May 2025 19:07:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746644862; cv=none; b=nHLxgmdDeD/YwCkOcSFqdj1aj0XlHpnAw7leQRcNrT2B9W/ZUrH5mX6NpGJfIsLY8wp7lVuH9mtzq6JiOFj770ZrmS5/AZKspPXPGxcSOPvYN+GbarVM9ME5Fj0cXh0i5KzIIT8s1t7QFt97NjI0CIdT2OnOIc7EPPFbvc1cZRg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746644862; c=relaxed/simple; bh=1c45j/KIe6jPzMiUvbTHu/iEQDeGt7H2yGAEqPbj4FY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ojmMB+nSnj9vu/72Yv0E/ZXPSDFWbxs4ETSjF0zfSvQYQTy0o9OBJNbhyq1osmjvIMa8BfvGoXTJ04hpxRt5KU/bWY8zwXougBYnQXgH5QA+LFOiOq9zlOiNYPZlTOpn1zVfaXPMnoGlWyVGCk1ECVkLMHQ+TPszi2dfuYeEOl4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=NIcbdDKI; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="NIcbdDKI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CD9D5C4CEE2; Wed, 7 May 2025 19:07:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1746644862; bh=1c45j/KIe6jPzMiUvbTHu/iEQDeGt7H2yGAEqPbj4FY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NIcbdDKIL17exbqKNII9jU1DpdgC4nPLJhse7wOuj/McDTfFSor+yOm6YR1MBLMNR vkOxNCCbjll9Iwx+2x0vFKbTTvWMqF7X8OP70dBJvyCh/D/FoKa7YaehXcNevf7iQI 6bxgNjdcdz1NV7aTQw3FryEFK4fGobORE+cNg3K8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ihar Salauyou , Ruslan Piasetskyi , Geert Uytterhoeven , Wolfram Sang , Ulf Hansson Subject: [PATCH 6.6 017/129] mmc: renesas_sdhi: Fix error handling in renesas_sdhi_probe Date: Wed, 7 May 2025 20:39:13 +0200 Message-ID: <20250507183814.233857569@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250507183813.500572371@linuxfoundation.org> References: <20250507183813.500572371@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ruslan Piasetskyi commit 649b50a82f09fa44c2f7a65618e4584072145ab7 upstream. After moving tmio_mmc_host_probe down, error handling has to be adjusted. Fixes: 74f45de394d9 ("mmc: renesas_sdhi: register irqs before registering controller") Reviewed-by: Ihar Salauyou Signed-off-by: Ruslan Piasetskyi Reviewed-by: Geert Uytterhoeven Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20250326220638.460083-1-ruslan.piasetskyi@gmail.com Signed-off-by: Ulf Hansson Signed-off-by: Greg Kroah-Hartman --- drivers/mmc/host/renesas_sdhi_core.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) --- a/drivers/mmc/host/renesas_sdhi_core.c +++ b/drivers/mmc/host/renesas_sdhi_core.c @@ -1107,26 +1107,26 @@ int renesas_sdhi_probe(struct platform_d num_irqs = platform_irq_count(pdev); if (num_irqs < 0) { ret = num_irqs; - goto eirq; + goto edisclk; } /* There must be at least one IRQ source */ if (!num_irqs) { ret = -ENXIO; - goto eirq; + goto edisclk; } for (i = 0; i < num_irqs; i++) { irq = platform_get_irq(pdev, i); if (irq < 0) { ret = irq; - goto eirq; + goto edisclk; } ret = devm_request_irq(&pdev->dev, irq, tmio_mmc_irq, 0, dev_name(&pdev->dev), host); if (ret) - goto eirq; + goto edisclk; } ret = tmio_mmc_host_probe(host); @@ -1138,8 +1138,6 @@ int renesas_sdhi_probe(struct platform_d return ret; -eirq: - tmio_mmc_host_remove(host); edisclk: renesas_sdhi_clk_disable(host); efree: