From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 379F4298CD1; Mon, 12 May 2025 18:08:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747073332; cv=none; b=sDTXRkvXaPAdopLsmzmYfj12oc4XO3YNbbzcP4pWlZ8MfVpTO0I2m6YcAwjXhItz7YaB9HZmL7oYhkG3FHtd0ZzyJbsQp/g7kam4ZAJhmF20eF4lsOQRHXhGV/2+sEPpHN8FhxY2eX+90uYhAYl3/X2EJWnUDCd1cnHsY6JBVfw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747073332; c=relaxed/simple; bh=ghk6SUX7LGbgPaZ4JDPxB+5DxnMU/zX7EV4n4AJVfG8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=U370q7WCpSXKQZVJ/lZ1FmIqdNrV7BCNDJdy2pp9BPqmmN69ea4Und7mf/M45N6mXnOtGRxQcQq2wPJoXBdQknCqstbQZDQ1Kcoq4ce1VtYptnjadVIO7byh18n+qVOO95pT/UcuEIZHX3RubxVHQBwa8lNKcaZAJFOyFMvH/+o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Svkqe40s; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Svkqe40s" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BF540C4CEFF; Mon, 12 May 2025 18:08:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1747073331; bh=ghk6SUX7LGbgPaZ4JDPxB+5DxnMU/zX7EV4n4AJVfG8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Svkqe40sCXKDHcU1Pzh7C4+w/IRPqy35H3ocMlzwaXm5eJbwd/8jHYm/PMyt186QT hhLREAz0TSyisTqFgZFlJdhbEG3gsmkIXeOE9wra+ub4+vMxBx+5AsoRcGf0JIbeuc 06nQhzf/JFRSwzZR2YsxXmmxljPS0Ujm7fxcZe6Q= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Mario Limonciello , Alex Deucher , Ray Wu , Wayne Lin , Daniel Wheeler Subject: [PATCH 6.6 041/113] drm/amd/display: Shift DMUB AUX reply command if necessary Date: Mon, 12 May 2025 19:45:30 +0200 Message-ID: <20250512172029.342073351@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250512172027.691520737@linuxfoundation.org> References: <20250512172027.691520737@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Wayne Lin commit 5a3846648c0523fd850b7f0aec78c0139453ab8b upstream. [Why] Defined value of dmub AUX reply command field get updated but didn't adjust dm receiving side accordingly. [How] Check the received reply command value to see if it's updated version or not. Adjust it if necessary. Fixes: ead08b95fa50 ("drm/amd/display: Fix race condition in DPIA AUX transfer") Cc: Mario Limonciello Cc: Alex Deucher Reviewed-by: Ray Wu Signed-off-by: Wayne Lin Signed-off-by: Ray Wu Tested-by: Daniel Wheeler Signed-off-by: Alex Deucher (cherry picked from commit d5c9ade755a9afa210840708a12a8f44c0d532f4) Cc: stable@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -11058,8 +11058,11 @@ int amdgpu_dm_process_dmub_aux_transfer_ goto out; } + payload->reply[0] = adev->dm.dmub_notify->aux_reply.command & 0xF; + if (adev->dm.dmub_notify->aux_reply.command & 0xF0) + /* The reply is stored in the top nibble of the command. */ + payload->reply[0] = (adev->dm.dmub_notify->aux_reply.command >> 4) & 0xF; - payload->reply[0] = adev->dm.dmub_notify->aux_reply.command; if (!payload->write && p_notify->aux_reply.length && (payload->reply[0] == AUX_TRANSACTION_REPLY_AUX_ACK)) {