From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90D9C29AAF8; Mon, 12 May 2025 18:10:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747073455; cv=none; b=jXEQ8PmE3DOhx4wl3ON1sjBM9BXomylUjz1N2/Uvs82bStKVbt1/sOKh6BTthgBn8wkOEX3MjUmdFqba0gsjfVzHF6n4bKVrgOV8pCjMNvoUbS5LZgEIk9XaUk4WLCjy7PRWSqj5wuBaCEXZnMa9b5vyWPmCMreB60bDxxvQLEk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747073455; c=relaxed/simple; bh=1cJ9nsDzMjaoETvOHgocUSgEw6pe0f/nr+fAAAhiiZM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Sb5ZGj7rFmbjZVCTJrcc2O7XPtwdhNmso9zg/xv9bT9tMxlCGPz6rpF/wtZ2smhY5EjD24cpnmeD9XO6YD3nzHeUe16dRkssmjasdiE+GRnYkYeNkSiykNH8TWjFsnr/J5JnN1x/pRmcsrCdLbRCFNA9zZPQSVwYgrGkSj0+JE0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=GX2Nci3J; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="GX2Nci3J" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C232C4CEE7; Mon, 12 May 2025 18:10:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1747073455; bh=1cJ9nsDzMjaoETvOHgocUSgEw6pe0f/nr+fAAAhiiZM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GX2Nci3J7gcInjUmQ+8owHDtCpjWcyDrbS8W32nNJH4tnm4+ZcZ0OZNVs6E7vi6t4 JPr9bYNIR+FDo45sV3kXL7lN890i7F6MFWBLld7joSr53fPgMwU/F5ndIawVka3kmK 6mokV/HfrcExiXy40S1A/xJgRHJsyX2bJnMW8l+8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Lothar Rubusch , Marcelo Schmitt , Jonathan Cameron , Sasha Levin Subject: [PATCH 6.6 079/113] iio: accel: adxl367: fix setting odr for activity time update Date: Mon, 12 May 2025 19:46:08 +0200 Message-ID: <20250512172030.901246641@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250512172027.691520737@linuxfoundation.org> References: <20250512172027.691520737@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Lothar Rubusch [ Upstream commit 38f67d0264929762e54ae5948703a21f841fe706 ] Fix setting the odr value to update activity time based on frequency derrived by recent odr, and not by obsolete odr value. The [small] bug: When _adxl367_set_odr() is called with a new odr value, it first writes the new odr value to the hardware register ADXL367_REG_FILTER_CTL. Second, it calls _adxl367_set_act_time_ms(), which calls adxl367_time_ms_to_samples(). Here st->odr still holds the old odr value. This st->odr member is used to derrive a frequency value, which is applied to update ADXL367_REG_TIME_ACT. Hence, the idea is to update activity time, based on possibilities and power consumption by the current ODR rate. Finally, when the function calls return, again in _adxl367_set_odr() the new ODR is assigned to st->odr. The fix: When setting a new ODR value is set to ADXL367_REG_FILTER_CTL, also ADXL367_REG_TIME_ACT should probably be updated with a frequency based on the recent ODR value and not the old one. Changing the location of the assignment to st->odr fixes this. Fixes: cbab791c5e2a5 ("iio: accel: add ADXL367 driver") Signed-off-by: Lothar Rubusch Reviewed-by: Marcelo Schmitt Link: https://patch.msgid.link/20250309193515.2974-1-l.rubusch@gmail.com Signed-off-by: Jonathan Cameron Signed-off-by: Sasha Levin --- drivers/iio/accel/adxl367.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/iio/accel/adxl367.c b/drivers/iio/accel/adxl367.c index 484fe2e9fb174..3a55475691de3 100644 --- a/drivers/iio/accel/adxl367.c +++ b/drivers/iio/accel/adxl367.c @@ -620,18 +620,14 @@ static int _adxl367_set_odr(struct adxl367_state *st, enum adxl367_odr odr) if (ret) return ret; + st->odr = odr; + /* Activity timers depend on ODR */ ret = _adxl367_set_act_time_ms(st, st->act_time_ms); if (ret) return ret; - ret = _adxl367_set_inact_time_ms(st, st->inact_time_ms); - if (ret) - return ret; - - st->odr = odr; - - return 0; + return _adxl367_set_inact_time_ms(st, st->inact_time_ms); } static int adxl367_set_odr(struct iio_dev *indio_dev, enum adxl367_odr odr) -- 2.39.5