From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0899F24502E; Tue, 20 May 2025 13:54:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747749242; cv=none; b=IEx/aoOB697Bdekvsf58eWqwZuX1WiRBGeuWgJ79c4KI8wKhnHTnvmIQMwU4vxt6vwI1l0q5702L4JDRwRh7bI/9obd7FD7OCxwZlfXjwH48Oi3bpGPEz5wEBhGt2zGjSkjOmnFCatFOry86NTGClpeRX6vUyMzoepuClX3ngFE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747749242; c=relaxed/simple; bh=TMv6qVTZFnp4ZueucT6jQNJzWPO8rfXYE/EKJ2FMmjU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=V5jkS3hb8vIV5R55OEJW5KJdPTutB27MFnHgxBqGMXLw8XCHZKFs6WsBg/qZTle9XbiGW8F4admeGztrvQSRwNFbGDw7YEw6xukfcmXCY0FnAwWMjKh5iQE0iK0kmP3wpn6Jd1UVYXnFzMDVJ336WA+D++5ztyXR284nkb/3S60= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=xlwzHW+q; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="xlwzHW+q" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 062AEC4CEE9; Tue, 20 May 2025 13:54:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1747749241; bh=TMv6qVTZFnp4ZueucT6jQNJzWPO8rfXYE/EKJ2FMmjU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xlwzHW+qzxtm466vAUkyZBMuhBFLvYoUIUxtwkChGfIOOeVQ2EbKui0xmqdzDAtqb Ovx8LSI7gRzFx3U/FuiCFMmLlPGdb2uC5vDk65I3p9/wFsieB8x6lbaTFXBzf7U5A5 fSOv/JnuTuBs1h1uY+UkYv4XP9EVnKmbCcRADgZ8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Fedor Pchelkin , Ming Yen Hsieh , Felix Fietkau Subject: [PATCH 5.15 41/59] wifi: mt76: disable napi on driver removal Date: Tue, 20 May 2025 15:50:32 +0200 Message-ID: <20250520125755.481263130@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250520125753.836407405@linuxfoundation.org> References: <20250520125753.836407405@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Fedor Pchelkin commit 78ab4be549533432d97ea8989d2f00b508fa68d8 upstream. A warning on driver removal started occurring after commit 9dd05df8403b ("net: warn if NAPI instance wasn't shut down"). Disable tx napi before deleting it in mt76_dma_cleanup(). WARNING: CPU: 4 PID: 18828 at net/core/dev.c:7288 __netif_napi_del_locked+0xf0/0x100 CPU: 4 UID: 0 PID: 18828 Comm: modprobe Not tainted 6.15.0-rc4 #4 PREEMPT(lazy) Hardware name: ASUS System Product Name/PRIME X670E-PRO WIFI, BIOS 3035 09/05/2024 RIP: 0010:__netif_napi_del_locked+0xf0/0x100 Call Trace: mt76_dma_cleanup+0x54/0x2f0 [mt76] mt7921_pci_remove+0xd5/0x190 [mt7921e] pci_device_remove+0x47/0xc0 device_release_driver_internal+0x19e/0x200 driver_detach+0x48/0x90 bus_remove_driver+0x6d/0xf0 pci_unregister_driver+0x2e/0xb0 __do_sys_delete_module.isra.0+0x197/0x2e0 do_syscall_64+0x7b/0x160 entry_SYSCALL_64_after_hwframe+0x76/0x7e Tested with mt7921e but the same pattern can be actually applied to other mt76 drivers calling mt76_dma_cleanup() during removal. Tx napi is enabled in their *_dma_init() functions and only toggled off and on again inside their suspend/resume/reset paths. So it should be okay to disable tx napi in such a generic way. Found by Linux Verification Center (linuxtesting.org). Fixes: 2ac515a5d74f ("mt76: mt76x02: use napi polling for tx cleanup") Cc: stable@vger.kernel.org Signed-off-by: Fedor Pchelkin Tested-by: Ming Yen Hsieh Link: https://patch.msgid.link/20250506115540.19045-1-pchelkin@ispras.ru Signed-off-by: Felix Fietkau Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/mediatek/mt76/dma.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/net/wireless/mediatek/mt76/dma.c +++ b/drivers/net/wireless/mediatek/mt76/dma.c @@ -684,6 +684,7 @@ void mt76_dma_cleanup(struct mt76_dev *d int i; mt76_worker_disable(&dev->tx_worker); + napi_disable(&dev->tx_napi); netif_napi_del(&dev->tx_napi); for (i = 0; i < ARRAY_SIZE(dev->phy.q_tx); i++) {