From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55F301A08DF; Tue, 20 May 2025 14:16:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747750571; cv=none; b=ZtRhkIXqq4OcqPxbcQLJBrGqm/ym7FwoeGZYxi5TUeilJJR2JkDFTeNds1Ak9nFADDR9PhhGIKEOGmkmJg1JqgU0frcLFOFt8WxHVNUzeTWnGwNHWbW+C0qStUcOH6c7ajWCYNMgPn3JgYdd12TNw9OCDV1VqOgM2iyP8Z9XK18= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747750571; c=relaxed/simple; bh=lIOqelYtfamP2KWVRpYUewZuwnWMZBACWF+KTgbdvYg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WipO3WI9nmwY+YNlKu77/zQhTV/Q0dup5CUL+psSJL6AiC7ozIKHsFQoLPFZD8WGxPMhSYzIoAyNMbZ9sOCS7LEfOfC6IrYqQAE27NtLUXCTug0dR9ttu5b4iy+l3ESlObkij2JYgoEDxvhwAUfUnUCqzp7SVe0I6eJlaXuD15c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=IVKLThea; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="IVKLThea" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BC701C4CEE9; Tue, 20 May 2025 14:16:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1747750571; bh=lIOqelYtfamP2KWVRpYUewZuwnWMZBACWF+KTgbdvYg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IVKLThea50ROAGl1VaRI4WNNb/LV/g07LXU/JBrSFHIimqv3E9DbXtSNyXQz0KRZB rfDfnhemb5pKbYptefQbOvB6zxfSf//Vn5JPaV85q25jlRW2TrbNlBOZ2PdlEVylx2 o6Oxvc7Le/5z9u9s2Rz+bO0WOw0an8BQNSiH5gig= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Subbaraya Sundeep , Simon Horman , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.14 052/145] octeontx2-pf: macsec: Fix incorrect max transmit size in TX secy Date: Tue, 20 May 2025 15:50:22 +0200 Message-ID: <20250520125812.611812027@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250520125810.535475500@linuxfoundation.org> References: <20250520125810.535475500@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Subbaraya Sundeep [ Upstream commit 865ab2461375e3a5a2526f91f9a9f17b8931bc9e ] MASCEC hardware block has a field called maximum transmit size for TX secy. Max packet size going out of MCS block has be programmed taking into account full packet size which has L2 header,SecTag and ICV. MACSEC offload driver is configuring max transmit size as macsec interface MTU which is incorrect. Say with 1500 MTU of real device, macsec interface created on top of real device will have MTU of 1468(1500 - (SecTag + ICV)). This is causing packets from macsec interface of size greater than or equal to 1468 are not getting transmitted out because driver programmed max transmit size as 1468 instead of 1514(1500 + ETH_HDR_LEN). Fixes: c54ffc73601c ("octeontx2-pf: mcs: Introduce MACSEC hardware offloading") Signed-off-by: Subbaraya Sundeep Reviewed-by: Simon Horman Link: https://patch.msgid.link/1747053756-4529-1-git-send-email-sbhatta@marvell.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c b/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c index f3b9daffaec3c..4c7e0f345cb5b 100644 --- a/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c +++ b/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c @@ -531,7 +531,8 @@ static int cn10k_mcs_write_tx_secy(struct otx2_nic *pfvf, if (sw_tx_sc->encrypt) sectag_tci |= (MCS_TCI_E | MCS_TCI_C); - policy = FIELD_PREP(MCS_TX_SECY_PLCY_MTU, secy->netdev->mtu); + policy = FIELD_PREP(MCS_TX_SECY_PLCY_MTU, + pfvf->netdev->mtu + OTX2_ETH_HLEN); /* Write SecTag excluding AN bits(1..0) */ policy |= FIELD_PREP(MCS_TX_SECY_PLCY_ST_TCI, sectag_tci >> 2); policy |= FIELD_PREP(MCS_TX_SECY_PLCY_ST_OFFSET, tag_offset); -- 2.39.5