From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9155D21D3C6; Tue, 20 May 2025 04:58:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747717097; cv=none; b=mAcXdlKFobKYrqvR1jcWH8H5Lglc3ylA/xy9pMNjZNCRyj0QS6TpWYkf5aursfV5dulNWRXJ5FywivlwWWJOAMFihKAJ2XIY/VKUl9x1mZkmdNn145BPtbVJl8VjYtO0GR5CnjdpM9Z/svLOAB/CQvWg11FwWLbBghqoTuACb9M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747717097; c=relaxed/simple; bh=MBlWbA4wMpuoxg+pVoz6sHSDbF2DGVKREhsYA3mbNcI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SMY00AEFidlPbH906v0IQQjUarx3tEh7o9QfTGbFop3jp4fA891NXeEPROxBWZzCQ48Vqus4IGj/FxuDswOxHaPaNl8Hg8L3FiMR98PUS3Hr2czepjIDpWiEOvV+Rv6otE1tBLa4sXtm/088zAklS0vJq2kIJ45PrCDljBAyE7g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=isuUUkja; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="isuUUkja" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7877EC4CEE9; Tue, 20 May 2025 04:58:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1747717097; bh=MBlWbA4wMpuoxg+pVoz6sHSDbF2DGVKREhsYA3mbNcI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=isuUUkjaaAfuWY8irVYPxqm7HEK05v+6Jrq1LuQDz9DjOm3BrzCyTIVXH0tg+DYdr VMe4gv00vUgQNl+dz1U96ATyYwHn/BI//mtf3uql8iWhYTwsSVWSpA4ymWvtiwokwm vFNDcarg78fLjImFKljmPk0Y1YtXvpHxxJJ7uc14= Date: Tue, 20 May 2025 06:56:27 +0200 From: Greg Kroah-Hartman To: Justin Forbes Cc: stable@vger.kernel.org, patches@lists.linux.dev, syzbot+6af973a3b8dfd2faefdc@syzkaller.appspotmail.com, Lizhi Xu , Christoph Hellwig , Jens Axboe , Sasha Levin Subject: Re: [PATCH 6.14 162/197] loop: Add sanity check for read/write_iter Message-ID: <2025052059-unsteady-octagon-9321@gregkh> References: <20250512172044.326436266@linuxfoundation.org> <20250512172050.980575013@linuxfoundation.org> Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, May 19, 2025 at 06:19:26PM -0600, Justin Forbes wrote: > On Mon, May 12, 2025 at 11:51 AM Greg Kroah-Hartman > wrote: > > > > 6.14-stable review patch. If anyone has any objections, please let me know. > > > > ------------------ > > > > From: Lizhi Xu > > > > [ Upstream commit f5c84eff634ba003326aa034c414e2a9dcb7c6a7 ] > > > > Some file systems do not support read_iter/write_iter, such as selinuxfs > > in this issue. > > So before calling them, first confirm that the interface is supported and > > then call it. > > > > It is releavant in that vfs_iter_read/write have the check, and removal > > of their used caused szybot to be able to hit this issue. > > > > Fixes: f2fed441c69b ("loop: stop using vfs_iter__{read,write} for buffered I/O") > > Reported-by: syzbot+6af973a3b8dfd2faefdc@syzkaller.appspotmail.com > > Closes: https://syzkaller.appspot.com/bug?extid=6af973a3b8dfd2faefdc > > Signed-off-by: Lizhi Xu > > Reviewed-by: Christoph Hellwig > > Link: https://lore.kernel.org/r/20250428143626.3318717-1-lizhi.xu@windriver.com > > Signed-off-by: Jens Axboe > > Signed-off-by: Sasha Levin > > --- > > drivers/block/loop.c | 23 +++++++++++++++++++++++ > > 1 file changed, 23 insertions(+) > > We have had an issue failing to set up loop devices with CI and Linus' > tree since rc6, and once this patch hit stable it proved to be the > culprit. If I revert this patch, things work as they should. The > problem we are seeing is " > > More information can be found in: > https://github.com/coreos/fedora-coreos-tracker/issues/1948 > and > https://openqa.fedoraproject.org/tests/3438220#step/_boot_to_anaconda/5 Sorry to hear that, please work with the developers to get this resolved in Linus's tree and then we will be glad to apply the needed fix from there. thanks, greg k-h