From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43A142110E; Tue, 27 May 2025 17:42:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748367723; cv=none; b=Nfz++melUkp9OkTjzIcUoKlXUtDVsOvI+Jhj9NWudBsDKD1OCKOX3Pwitx3QuyWpZOv4hvUtiIOxpL3gFQ9+I6dALhmRRx0zDRG+kLHjjjGNDXHA/kHsI0TGgWDlHJnukmKhuaVQHAZ2kVopN+qhmKy9daBumdx58u/rQFld9H8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748367723; c=relaxed/simple; bh=evJdFz5aTScTs2ZPFwjq3FVVgLqE9dUlxVlZQaz4cPI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cvUtD7NMAaDjaOObXXeFFjfxMSUQYsb8OL3af3uv/x5mD1J8P1N34ogbb/SdVDR1w3sHf2sDBuDjVWiZAJk8mIfYj44PIhyPqc1VCngEdokaZRzJL0kUVgvoP6jem6l1QER+yz3zMZga/c4IiKkqsmi4Lx4MkVtNeD2lJXBzunk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=N+95Q/Kt; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="N+95Q/Kt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C9A36C4CEE9; Tue, 27 May 2025 17:42:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1748367723; bh=evJdFz5aTScTs2ZPFwjq3FVVgLqE9dUlxVlZQaz4cPI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=N+95Q/Ktj6BXeQIoMGQma41B5wPMEsW6vG/AveOFoox4//mJepe+QZTx9i/ZwUaOI S4OMsIjNbodfMRsQfrvF30l/9mNpBViR35MzB74uEJFP3QMms6BD9EQBF38QIGn2a3 xOnN6FGuxcm3RW2b4ec8msIAltiN//zCPVO6ZVfI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Brendan Jackman , David Gow , Shuah Khan , Sasha Levin Subject: [PATCH 6.14 448/783] kunit: tool: Use qboot on QEMU x86_64 Date: Tue, 27 May 2025 18:24:05 +0200 Message-ID: <20250527162531.376292103@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250527162513.035720581@linuxfoundation.org> References: <20250527162513.035720581@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Brendan Jackman [ Upstream commit 08fafac4c9f289a9d9a22d838921e4b3eb22c664 ] As noted in [0], SeaBIOS (QEMU default) makes a mess of the terminal, qboot does not. It turns out this is actually useful with kunit.py, since the user is exposed to this issue if they set --raw_output=all. qboot is also faster than SeaBIOS, but it's is marginal for this usecase. [0] https://lore.kernel.org/all/CA+i-1C0wYb-gZ8Mwh3WSVpbk-LF-Uo+njVbASJPe1WXDURoV7A@mail.gmail.com/ Both SeaBIOS and qboot are x86-specific. Link: https://lore.kernel.org/r/20250124-kunit-qboot-v1-1-815e4d4c6f7c@google.com Signed-off-by: Brendan Jackman Reviewed-by: David Gow Signed-off-by: Shuah Khan Signed-off-by: Sasha Levin --- tools/testing/kunit/qemu_configs/x86_64.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/testing/kunit/qemu_configs/x86_64.py b/tools/testing/kunit/qemu_configs/x86_64.py index dc79490768630..4a6bf4e048f5b 100644 --- a/tools/testing/kunit/qemu_configs/x86_64.py +++ b/tools/testing/kunit/qemu_configs/x86_64.py @@ -7,4 +7,6 @@ CONFIG_SERIAL_8250_CONSOLE=y''', qemu_arch='x86_64', kernel_path='arch/x86/boot/bzImage', kernel_command_line='console=ttyS0', - extra_qemu_params=[]) + # qboot is faster than SeaBIOS and doesn't mess up + # the terminal. + extra_qemu_params=['-bios', 'qboot.rom']) -- 2.39.5