From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E34322A801; Mon, 2 Jun 2025 15:14:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748877259; cv=none; b=kjKEoJDArz2IcuGLQPUbGpvwrHa+5QOgnzNX9N/jCIGNaXBZIDEhFVHRTbe3osHe41Z3NSkI1OQ+ehjjGD/xvi/aG62LTRJLvbaKsL2m02SbGJP82uyHrsxMWV71hsuBdB5d2JH0BGyLYPmpvsXYIAvg4IYmuNeRCIBg04v5L3A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748877259; c=relaxed/simple; bh=BiHEkZF7hrSUOklejltvgy3hfpc15T80njz2pWoyxLk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DzfMLl3WTgpU51mZxhtu5b+xpdNHxfgZ58Nd5zAEeqfB/Apms9hUxJXalQ//m8YwOrvJ9u24uSnB1iuZbGh6cUq+ODbsV1be3y8odODkifdtcbU8TNOJVNhrTptzCZobUi1Fmk49XX77NkIv5J2owknsAuj67NYTR9gnkd4jr+4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=fzrS8YdF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="fzrS8YdF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8433BC4CEEB; Mon, 2 Jun 2025 15:14:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1748877257; bh=BiHEkZF7hrSUOklejltvgy3hfpc15T80njz2pWoyxLk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fzrS8YdFQWPOrEEc3pwcogOuDmSMLuo62/xJssM4RJR3fsfLjZmlufAwo055xbbKG WHjiqRYHg4Mg5ng4oi8XF5Glk5Kx4UxvOwBRPUUy2yuaz+HX4di6IfL1Ypwc2LvPIv hJxA4SsnnD6IViX6JjrMopqyV/uzXYOllF796QXo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Martin Blumenstingl , Neil Armstrong , Linus Walleij , Sasha Levin Subject: [PATCH 6.1 221/325] pinctrl: meson: define the pull up/down resistor value as 60 kOhm Date: Mon, 2 Jun 2025 15:48:17 +0200 Message-ID: <20250602134328.766823333@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250602134319.723650984@linuxfoundation.org> References: <20250602134319.723650984@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Martin Blumenstingl [ Upstream commit e56088a13708757da68ad035269d69b93ac8c389 ] The public datasheets of the following Amlogic SoCs describe a typical resistor value for the built-in pull up/down resistor: - Meson8/8b/8m2: not documented - GXBB (S905): 60 kOhm - GXL (S905X): 60 kOhm - GXM (S912): 60 kOhm - G12B (S922X): 60 kOhm - SM1 (S905D3): 60 kOhm The public G12B and SM1 datasheets additionally state min and max values: - min value: 50 kOhm for both, pull-up and pull-down - max value for the pull-up: 70 kOhm - max value for the pull-down: 130 kOhm Use 60 kOhm in the pinctrl-meson driver as well so it's shown in the debugfs output. It may not be accurate for Meson8/8b/8m2 but in reality 60 kOhm is closer to the actual value than 1 Ohm. Signed-off-by: Martin Blumenstingl Reviewed-by: Neil Armstrong Link: https://lore.kernel.org/20250329190132.855196-1-martin.blumenstingl@googlemail.com Signed-off-by: Linus Walleij Signed-off-by: Sasha Levin --- drivers/pinctrl/meson/pinctrl-meson.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/meson/pinctrl-meson.c b/drivers/pinctrl/meson/pinctrl-meson.c index 530f3f934e196..1f05f7f1a9aee 100644 --- a/drivers/pinctrl/meson/pinctrl-meson.c +++ b/drivers/pinctrl/meson/pinctrl-meson.c @@ -487,7 +487,7 @@ static int meson_pinconf_get(struct pinctrl_dev *pcdev, unsigned int pin, case PIN_CONFIG_BIAS_PULL_DOWN: case PIN_CONFIG_BIAS_PULL_UP: if (meson_pinconf_get_pull(pc, pin) == param) - arg = 1; + arg = 60000; else return -EINVAL; break; -- 2.39.5