From: Jason Gunthorpe <jgg@nvidia.com>
To: Baolu Lu <baolu.lu@linux.intel.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
iommu@lists.linux.dev, Joerg Roedel <joro@8bytes.org>,
Robin Murphy <robin.murphy@arm.com>,
Will Deacon <will@kernel.org>,
patches@lists.linux.dev, Wei Wang <wei.w.wang@intel.com>
Subject: Re: [PATCH 7/7] iommu/vtd: Split paging_domain_compatible()
Date: Tue, 10 Jun 2025 20:51:25 -0300 [thread overview]
Message-ID: <20250610235125.GP543171@nvidia.com> (raw)
In-Reply-To: <39400661-9f18-4ba3-8cb8-d56ef548c9b0@linux.intel.com>
On Tue, Jun 10, 2025 at 03:12:43PM +0800, Baolu Lu wrote:
> > + /*
> > + * FIXME this is locked wrong, it needs to be under the
> > + * dmar_domain->lock
> > + */
> > if (dmar_domain->force_snooping && !ecap_sc_support(iommu->ecap))
> > return -EINVAL;
>
> Perhaps we can use group->mutex to fix this in the future?
It is part of the iommu_domain, there is no clear group->mutex that
is affiliated with a domain, there can be multiple devices attached..
Maybe we should change the enforce coherency away from a function op
and into a domain creation flag. Then it won't change at run time,
fixing this race, and we don't have the issue of possibly having PTEs
with the wrong bit already mapped into the domain.
When this was first done that was harder, but now I think we have
enough infrastructure to do it easily..
Jason
next prev parent reply other threads:[~2025-06-10 23:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-09 19:58 [PATCH 0/7] Reorganize Intel VT-D to be ready for iommupt Jason Gunthorpe
2025-06-09 19:58 ` [PATCH 1/7] iommu/vtd: Lift the __pa to domain_setup_first_level/intel_svm_set_dev_pasid() Jason Gunthorpe
2025-06-10 18:34 ` Jason Gunthorpe
2025-06-09 19:58 ` [PATCH 2/7] iommu/vtd: Fold domain_exit() into intel_iommu_domain_free() Jason Gunthorpe
2025-06-10 9:15 ` Wang, Wei W
2025-06-10 13:29 ` Jason Gunthorpe
2025-06-09 19:58 ` [PATCH 3/7] iommu/vtd: Do not wipe out the page table NID when devices detach Jason Gunthorpe
2025-06-10 6:41 ` Baolu Lu
2025-06-10 13:18 ` Jason Gunthorpe
2025-06-10 9:14 ` Wang, Wei W
2025-06-09 19:58 ` [PATCH 4/7] iommu/vtd: Split intel_iommu_domain_alloc_paging_flags() Jason Gunthorpe
2025-06-10 9:14 ` Wang, Wei W
2025-06-10 13:25 ` Jason Gunthorpe
2025-06-09 19:58 ` [PATCH 5/7] iommu/vtd: Create unique domain ops for each stage Jason Gunthorpe
2025-06-10 9:14 ` Wang, Wei W
2025-06-10 13:26 ` Jason Gunthorpe
2025-06-09 19:58 ` [PATCH 6/7] iommu/vtd: Split intel_iommu_enforce_cache_coherency() Jason Gunthorpe
2025-06-09 19:58 ` [PATCH 7/7] iommu/vtd: Split paging_domain_compatible() Jason Gunthorpe
2025-06-10 7:12 ` Baolu Lu
2025-06-10 23:51 ` Jason Gunthorpe [this message]
2025-06-11 4:50 ` Baolu Lu
2025-06-12 13:47 ` Jason Gunthorpe
2025-06-13 3:15 ` Baolu Lu
2025-06-12 7:18 ` [PATCH 0/7] Reorganize Intel VT-D to be ready for iommupt Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250610235125.GP543171@nvidia.com \
--to=jgg@nvidia.com \
--cc=baolu.lu@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=patches@lists.linux.dev \
--cc=robin.murphy@arm.com \
--cc=wei.w.wang@intel.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).