From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B9C6285048; Tue, 17 Jun 2025 16:16:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750177001; cv=none; b=BLKT9TjOpnOXDA0uPqXPF0hWWd/koKGqICQfx3mfYHGdml02IR97ZZOtkYloGu3JLSoM3fZFqHyajsWQnw8HwX4AaChmFpC1rTYm1CtIGrCcVthxm+4SvDMKHn8pBREc5iyL3fXxTjiudTK69EDYleNi+0F8VfAP+j3xVS2R4Jc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750177001; c=relaxed/simple; bh=gF8RYdiQ7oiBxa1J5tX7gTKyU39ww4SBE1KtvaWYZwA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=F/CHy0WRW/MaIuCS+0Jl3iN9lh4VpNf3lYrusOlg3iOOIlyoFK2CQxDjeAWxMWPA8WJSFKsQ3hL4VthI/U/mfXvYGVov5b0tctlJjg3Z7Qpw76igH5kCzYi3RVTmLnJVARVWjh8VJp39xV3nFn1amcJsXenl+Mxru+ebCVJ1faM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ajZbDm98; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ajZbDm98" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 958C2C4CEE3; Tue, 17 Jun 2025 16:16:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1750177001; bh=gF8RYdiQ7oiBxa1J5tX7gTKyU39ww4SBE1KtvaWYZwA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ajZbDm98W94NRCIInoH7wNfzu3HnaOGqfv+om7JUK8b+yrtJ7h2N3NZzHzeV3H8Id A5VSmFSa7tSQtLtB3ENs9vsU56c3M+I5I1CRL5fF+An2zvDZThx9oek12saj3vkN9E UtA7U7IzpVF59Gi6MJ75kR9+gFZ1+nWVpl0DJBBI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Dan Carpenter , Dmitry Baryshkov , Bjorn Andersson , Sasha Levin Subject: [PATCH 6.12 287/512] remoteproc: qcom_wcnss_iris: Add missing put_device() on error in probe Date: Tue, 17 Jun 2025 17:24:13 +0200 Message-ID: <20250617152431.231484893@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250617152419.512865572@linuxfoundation.org> References: <20250617152419.512865572@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dan Carpenter [ Upstream commit 0cb4b1b97041d8a1f773425208ded253c1cb5869 ] The device_del() call matches with the device_add() but we also need to call put_device() to trigger the qcom_iris_release(). Fixes: 1fcef985c8bd ("remoteproc: qcom: wcnss: Fix race with iris probe") Signed-off-by: Dan Carpenter Reviewed-by: Dmitry Baryshkov Link: https://lore.kernel.org/r/4604f7e0-3217-4095-b28a-3ff8b5afad3a@stanley.mountain Signed-off-by: Bjorn Andersson Signed-off-by: Sasha Levin --- drivers/remoteproc/qcom_wcnss_iris.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/remoteproc/qcom_wcnss_iris.c b/drivers/remoteproc/qcom_wcnss_iris.c index dd36fd077911a..1e197f7734742 100644 --- a/drivers/remoteproc/qcom_wcnss_iris.c +++ b/drivers/remoteproc/qcom_wcnss_iris.c @@ -197,6 +197,7 @@ struct qcom_iris *qcom_iris_probe(struct device *parent, bool *use_48mhz_xo) err_device_del: device_del(&iris->dev); + put_device(&iris->dev); return ERR_PTR(ret); } @@ -204,4 +205,5 @@ struct qcom_iris *qcom_iris_probe(struct device *parent, bool *use_48mhz_xo) void qcom_iris_remove(struct qcom_iris *iris) { device_del(&iris->dev); + put_device(&iris->dev); } -- 2.39.5