From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6307C255E23; Mon, 23 Jun 2025 13:10:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750684208; cv=none; b=t9UBn3RproPF2cY9TJCcZ++pUWbIER+0mgCoEpu7EPN+iJGB090erVSfITgOFVeNZgHAHjobqiOHIIVS2xqdSoPZONigE7Foh1p21CE4WyhufPzBTL6cQQT9Yqq8eTBy5/Hz0A7TMbA6EQCY6CvsrQzO3ZLBdf++k6PuDDByXgU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750684208; c=relaxed/simple; bh=gAyepmdp2PEfkaH4cE6Zimyzi0tGPCnDsEKUhKIyaR0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sDPZpJRvekEhELy0ZsK+pNlk/u8Lme3zchooZKcKlT+TBshnTDe4vTRG+xYsEfFMcD6+iin76Hn/clem5wxbmcPh8ymDQ76bPjRsepAfcbt9cJkNxkGkCgtoWDAD977bzBpHfrWleIQ+oEVcKRG/GjYX67vHcMHghbUtdlaWejQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=t8YojDOD; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="t8YojDOD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E2A94C4CEEA; Mon, 23 Jun 2025 13:10:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1750684208; bh=gAyepmdp2PEfkaH4cE6Zimyzi0tGPCnDsEKUhKIyaR0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=t8YojDODmTkS92V7ra55agYMO1GE4BocZlvt9KAxl7M02dSEsPGi/qGcRmnJABUZA WHbOxTXEjFf+M5skhSHn9JsFd3RSLHQ0/4QoiQLn6rsenTlStE2dgBnXJonEF+6ZmF ECnF9UdHbOPBTNUqT1d0hz/BMCE2lteB5MJpXlMc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Imre Kaloz , Andrew Lunn , Gabor Juhos , Linus Walleij Subject: [PATCH 5.10 002/355] pinctrl: armada-37xx: use correct OUTPUT_VAL register for GPIOs > 31 Date: Mon, 23 Jun 2025 15:03:23 +0200 Message-ID: <20250623130626.794612669@linuxfoundation.org> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250623130626.716971725@linuxfoundation.org> References: <20250623130626.716971725@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Gabor Juhos commit 947c93eb29c2a581c0b0b6d5f21af3c2b7ff6d25 upstream. The controller has two consecutive OUTPUT_VAL registers and both holds output value for 32 GPIOs. Due to a missing adjustment, the current code always uses the first register while setting the output value whereas it should use the second one for GPIOs > 31. Add the missing armada_37xx_update_reg() call to adjust the register according to the 'offset' parameter of the function to fix the issue. Cc: stable@vger.kernel.org Fixes: 6702abb3bf23 ("pinctrl: armada-37xx: Fix direction_output() callback behavior") Signed-off-by: Imre Kaloz Reviewed-by: Andrew Lunn Signed-off-by: Gabor Juhos Link: https://lore.kernel.org/20250514-pinctrl-a37xx-fixes-v2-1-07e9ac1ab737@gmail.com Signed-off-by: Linus Walleij Signed-off-by: Greg Kroah-Hartman --- drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c +++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c @@ -413,6 +413,7 @@ static int armada_37xx_gpio_direction_ou unsigned int offset, int value) { struct armada_37xx_pinctrl *info = gpiochip_get_data(chip); + unsigned int val_offset = offset; unsigned int reg = OUTPUT_EN; unsigned int mask, val, ret; @@ -425,6 +426,8 @@ static int armada_37xx_gpio_direction_ou return ret; reg = OUTPUT_VAL; + armada_37xx_update_reg(®, &val_offset); + val = value ? mask : 0; regmap_update_bits(info->regmap, reg, mask, val);