From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7EEF253B56; Mon, 23 Jun 2025 13:30:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750685452; cv=none; b=Yuk8UJI5bMSoB+6P39VbbXeIoC9tUky2rj6WbjkpcDEZomyxf5btmU2gs4MHtx5lhw0LlD0JjH//8BlP3zlMUS8i8fOfDzlECHtwQTSnxcvsXAUrqUB+iri2JellAV/dMgJBDzKFkI5oCJ0ITC4lTufXRTVayV0r0bfxBNpJLQg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750685452; c=relaxed/simple; bh=XiMe01OOkXOFoGbfIMMQ3MdobT2hhDrl1aCC6w6+O3U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cMUKfzoiHx+nebFL0agJFmqzTdqxIfzFDaSBMVWfYt1euLg/CIiV9VficLgn3p21sGMcfKbiI/5oUvWZi0+5i4W9E4oT3MSysJAo+yrfZjcfCHYBk93uaDL9teNh4JXfR8Vi7wPfsyxk9kYIHL6zOkz4xFTEaz7iGhNDQK5Yu7k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=d8yLnoRY; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="d8yLnoRY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B5B79C4CEEA; Mon, 23 Jun 2025 13:30:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1750685451; bh=XiMe01OOkXOFoGbfIMMQ3MdobT2hhDrl1aCC6w6+O3U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=d8yLnoRYWatTCrQmjIvJLjAUkzE5JswJComIv61+XUBDvHYaQeCnMlRMyhgIolwDh qDZxgmiB6FVFthxyBXrE7Xt8NsoNVgWWRNdyYVOKO2uI8sUj+0o48RyUOhe68One45 aesWJTF93IDZMUGUwkzdAUOSU6w9EzwrD0c5KP1k= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Henry Martin , Dmitry Baryshkov , "Daniel Thompson (RISCstar)" , Lee Jones , Sasha Levin Subject: [PATCH 5.10 076/355] backlight: pm8941: Add NULL check in wled_configure() Date: Mon, 23 Jun 2025 15:04:37 +0200 Message-ID: <20250623130629.106558386@linuxfoundation.org> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250623130626.716971725@linuxfoundation.org> References: <20250623130626.716971725@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Henry Martin [ Upstream commit e12d3e1624a02706cdd3628bbf5668827214fa33 ] devm_kasprintf() returns NULL when memory allocation fails. Currently, wled_configure() does not check for this case, which results in a NULL pointer dereference. Add NULL check after devm_kasprintf() to prevent this issue. Fixes: f86b77583d88 ("backlight: pm8941: Convert to using %pOFn instead of device_node.name") Signed-off-by: Henry Martin Reviewed-by: Dmitry Baryshkov Reviewed-by: "Daniel Thompson (RISCstar)" Link: https://lore.kernel.org/r/20250401091647.22784-1-bsdhenrymartin@gmail.com Signed-off-by: Lee Jones Signed-off-by: Sasha Levin --- drivers/video/backlight/qcom-wled.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c index 486d35da01507..54c4bb66009fc 100644 --- a/drivers/video/backlight/qcom-wled.c +++ b/drivers/video/backlight/qcom-wled.c @@ -1404,9 +1404,11 @@ static int wled_configure(struct wled *wled) wled->ctrl_addr = be32_to_cpu(*prop_addr); rc = of_property_read_string(dev->of_node, "label", &wled->name); - if (rc) + if (rc) { wled->name = devm_kasprintf(dev, GFP_KERNEL, "%pOFn", dev->of_node); - + if (!wled->name) + return -ENOMEM; + } switch (wled->version) { case 3: u32_opts = wled3_opts; -- 2.39.5