From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF6D9219E0; Mon, 23 Jun 2025 21:24:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750713869; cv=none; b=dx2J/+vuBUZBWM7vvSzQHgkSN4jFfNJBXvn7G44BbvHyS/PXD0wV5Vf9fzZIC/fDn4j7UadzpRxETzAg2QOY1E7Av328yyE0oZFP7q8zQTuUnfS4dItuWBaNpOHBM9E/MJp4gry+nkUw61JYanByIajLecPDybJqvnp2Tc/6GfA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750713869; c=relaxed/simple; bh=MAauTzw7ROySuRmxEGh+a4NBj04ieHMjMkf3Inv7UZY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uuW+vQl6fzRniInabZwl3vWHLZFRpSGyv65az6zDHALBwBDU1FwCTUtheZhl0vM+wC3DDJX1oregf/t1kum9gQmmCJKIAwpSNKqfGFu/2DpmNcYqhP9yXRJ54kxptqsuK/K5u8y7Xmz3oZd9BgDMt0JflAZ7GVDSynng1a+JOP4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=NpNtS+5O; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="NpNtS+5O" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0C231C4CEEA; Mon, 23 Jun 2025 21:24:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1750713869; bh=MAauTzw7ROySuRmxEGh+a4NBj04ieHMjMkf3Inv7UZY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NpNtS+5OWnfWQh9HpH5Brl3gPBf3XSFEscauYOim6VX6jTRmwSBR7c2uUy7n8Fx4E tFI5Z5W3NkHPcv2c2ikYy+BR66ADSFH2QeGvc94K/113pc+Fqj5vYUi5u+CG7Rhc9q lD9P+KtLZrqTVo1Tv/2x2JBZPTraFEpNj4sAF9FU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Johan Hovold , Sakari Ailus , Hans Verkuil Subject: [PATCH 5.10 171/355] media: ov8856: suppress probe deferral errors Date: Mon, 23 Jun 2025 15:06:12 +0200 Message-ID: <20250623130631.852494679@linuxfoundation.org> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250623130626.716971725@linuxfoundation.org> References: <20250623130626.716971725@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Johan Hovold commit e3d86847fba58cf71f66e81b6a2515e07039ae17 upstream. Probe deferral should not be logged as an error: ov8856 24-0010: failed to get HW configuration: -517 Use dev_err_probe() for the clock lookup and drop the (mostly) redundant dev_err() from sensor probe() to suppress it. Note that errors during regulator lookup is already correctly logged using dev_err_probe(). Fixes: 0c2c7a1e0d69 ("media: ov8856: Add devicetree support") Cc: stable@vger.kernel.org Signed-off-by: Johan Hovold Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil Signed-off-by: Greg Kroah-Hartman --- drivers/media/i2c/ov8856.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) --- a/drivers/media/i2c/ov8856.c +++ b/drivers/media/i2c/ov8856.c @@ -1663,8 +1663,8 @@ static int ov8856_get_hwcfg(struct ov885 if (!is_acpi_node(fwnode)) { ov8856->xvclk = devm_clk_get(dev, "xvclk"); if (IS_ERR(ov8856->xvclk)) { - dev_err(dev, "could not get xvclk clock (%pe)\n", - ov8856->xvclk); + dev_err_probe(dev, PTR_ERR(ov8856->xvclk), + "could not get xvclk clock\n"); return PTR_ERR(ov8856->xvclk); } @@ -1758,11 +1758,8 @@ static int ov8856_probe(struct i2c_clien return -ENOMEM; ret = ov8856_get_hwcfg(ov8856, &client->dev); - if (ret) { - dev_err(&client->dev, "failed to get HW configuration: %d", - ret); + if (ret) return ret; - } v4l2_i2c_subdev_init(&ov8856->sd, client, &ov8856_subdev_ops);