From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53F8F1DDC04; Mon, 23 Jun 2025 21:33:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750714436; cv=none; b=HC67SIu40RLfKO9QYetD0kffHnnK0b8WpCYTjSJL+a54+vYWUVpsG7N0BV8Yeh3mqX6fKXEwXmjH7jnayA/4YkM9z6SAALWF/M1vv9FRCWZy6gHBboUNKEKTpaOi/BTjPAyFTc57TIjbqVpFEIqlpmJ3p8NE2Gs5lkRNljHUayI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750714436; c=relaxed/simple; bh=cacyccKlhFuJPy7Dk8dCzvMxqMoH7oVSF5zH4cjT6Vs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=m3CqgFHqjfT1S3u/RNjCr036F6vdmrJDr5x60UcN1lBD34++DWb6n0ZfnEbVe10ISKM9LOHakD8f9oGh5BQD8qWhQh0CarNmVSPMHvrrqu39gCR0CwY83k8c2PzWeSV+g37AxCiG5xStBxNfzS6VpN7IJIIWQl2+qn9SUu7Ts74= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=E0gltBMM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="E0gltBMM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6A8DC4CEEA; Mon, 23 Jun 2025 21:33:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1750714436; bh=cacyccKlhFuJPy7Dk8dCzvMxqMoH7oVSF5zH4cjT6Vs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=E0gltBMMF0zNfitOfdjkQnVyKhHTKjDAdrkEja6CCarP+IPx30mGf033aYgCO51XM BElzQjiMWhHIMwR96kRRI4m55q72CaneM0gApQjG+tSh7ieQf4BDETPuxRisWFfw1A Inm2o/0ak4GqaJJlVM2xiZdRC/DnQ3+jSV8fMGVA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Wentao Liang , Mark Brown Subject: [PATCH 5.10 206/355] regulator: max14577: Add error check for max14577_read_reg() Date: Mon, 23 Jun 2025 15:06:47 +0200 Message-ID: <20250623130632.911464985@linuxfoundation.org> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250623130626.716971725@linuxfoundation.org> References: <20250623130626.716971725@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Wentao Liang commit 65271f868cb1dca709ff69e45939bbef8d6d0b70 upstream. The function max14577_reg_get_current_limit() calls the function max14577_read_reg(), but does not check its return value. A proper implementation can be found in max14577_get_online(). Add a error check for the max14577_read_reg() and return error code if the function fails. Fixes: b0902bbeb768 ("regulator: max14577: Add regulator driver for Maxim 14577") Cc: stable@vger.kernel.org # v3.14 Signed-off-by: Wentao Liang Link: https://patch.msgid.link/20250526025627.407-1-vulab@iscas.ac.cn Signed-off-by: Mark Brown Signed-off-by: Greg Kroah-Hartman --- drivers/regulator/max14577-regulator.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) --- a/drivers/regulator/max14577-regulator.c +++ b/drivers/regulator/max14577-regulator.c @@ -40,11 +40,14 @@ static int max14577_reg_get_current_limi struct max14577 *max14577 = rdev_get_drvdata(rdev); const struct maxim_charger_current *limits = &maxim_charger_currents[max14577->dev_type]; + int ret; if (rdev_get_id(rdev) != MAX14577_CHARGER) return -EINVAL; - max14577_read_reg(rmap, MAX14577_CHG_REG_CHG_CTRL4, ®_data); + ret = max14577_read_reg(rmap, MAX14577_CHG_REG_CHG_CTRL4, ®_data); + if (ret < 0) + return ret; if ((reg_data & CHGCTRL4_MBCICHWRCL_MASK) == 0) return limits->min;