From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A934254B03; Mon, 23 Jun 2025 13:30:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750685405; cv=none; b=jHn/cdxv6SOvcch6U1PcslIDtlf5oNeCWy6ikaejU3Gd0w0Zxn/IvpNthG+QPiAa7Ayx+vV1Sp+82XmQKekmiFScMvvqD+///qBPbcWGfKVhke48XA8rpaKdPXWVo6uBdRLIBYxyLaBr3/F250QYWhgnKPboH/q+v4/imnxgP/g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750685405; c=relaxed/simple; bh=ETyVx9JaCeCPB8Uhl3YAomouKVmd1/tQHtQt2e9PPpM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VVQGoMFU77Y3SCt+GtNpZiSWQzEUt1Ym+hAEs4iUTF1oU87M/D2Vy4jbTmugbDDNjQvMgaimLIPRucYXjkWKFWJgaWZgCWEDyE0qXyFdzFbbvFmrLBV1xeDVOyaXMH8XLPEcVoDSiIRZhHBxkl+UxYlE+P+2f0g69YEt0eW4sdw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=oO0bOcv9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="oO0bOcv9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B4F04C4CEEA; Mon, 23 Jun 2025 13:30:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1750685405; bh=ETyVx9JaCeCPB8Uhl3YAomouKVmd1/tQHtQt2e9PPpM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oO0bOcv9OSW0hAxtGpyeSbcUt7mRkj2SAcp/sVrQwgy2PVEixG2NuaMNRWKG0MLTC Ze5Hp2UM5Pzm/hrs4pgi1NrBNkjiOiIhiPjGRQJ0GO/5iSCLvCE6yF7UIkG/Qe6Iae uHCVVpMIPdtpIPIyeXKcg1xGrUH6F6559VcniseY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Andy Shevchenko , Linus Walleij , Sasha Levin Subject: [PATCH 5.15 057/411] pinctrl: at91: Fix possible out-of-boundary access Date: Mon, 23 Jun 2025 15:03:21 +0200 Message-ID: <20250623130634.703510657@linuxfoundation.org> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250623130632.993849527@linuxfoundation.org> References: <20250623130632.993849527@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Andy Shevchenko [ Upstream commit 762ef7d1e6eefad9896560bfcb9bcf7f1b6df9c1 ] at91_gpio_probe() doesn't check that given OF alias is not available or something went wrong when trying to get it. This might have consequences when accessing gpio_chips array with that value as an index. Note, that BUG() can be compiled out and hence won't actually perform the required checks. Fixes: 6732ae5cb47c ("ARM: at91: add pinctrl support") Signed-off-by: Andy Shevchenko Closes: https://lore.kernel.org/r/202505052343.UHF1Zo93-lkp@intel.com/ Link: https://lore.kernel.org/20250508200807.1384558-1-andriy.shevchenko@linux.intel.com Signed-off-by: Linus Walleij Signed-off-by: Sasha Levin --- drivers/pinctrl/pinctrl-at91.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c index 9c92838428b8f..40080b0ad020a 100644 --- a/drivers/pinctrl/pinctrl-at91.c +++ b/drivers/pinctrl/pinctrl-at91.c @@ -1820,12 +1820,16 @@ static int at91_gpio_probe(struct platform_device *pdev) struct at91_gpio_chip *at91_chip = NULL; struct gpio_chip *chip; struct pinctrl_gpio_range *range; + int alias_idx; int ret = 0; int irq, i; - int alias_idx = of_alias_get_id(np, "gpio"); uint32_t ngpio; char **names; + alias_idx = of_alias_get_id(np, "gpio"); + if (alias_idx < 0) + return alias_idx; + BUG_ON(alias_idx >= ARRAY_SIZE(gpio_chips)); if (gpio_chips[alias_idx]) { ret = -EBUSY; -- 2.39.5