From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2BB819049B; Mon, 23 Jun 2025 21:49:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750715376; cv=none; b=L9gR5+vEFTxI/NXb0KiqMeQilbtnu4EEt+x/OEyXb1rvaHqnaNK3Hs0LUn743P6CmOStwRPFkBv+XfCV6NWzFn9+FpHF57RGYXE+BJsYHTdnODEtLMKkabb8aN0NxVuR3FxHB6gIKxHzizsDuKQaNfbts6DC64e/uyWg7ZyKRSs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750715376; c=relaxed/simple; bh=SNxeY0zZV+xuqFmn+RUUDNa4Go7YcxSAQH7yOlBmGmw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kT30SnfvHFlGuDaC896tdStIOn+HznGmpQU4NJz+euZsOYTnzALrxtw1BRtYK7wNOJsTkDbAvTcktzQny7UGZMct55UTO2lcv1eo1ppn2xxF5YnuCigwDZir/+Df36DUUSSzYJXRkBOwaXK39FADsZjVgI6ouFkL41WGrMkr8y8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=eJjKA+4s; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="eJjKA+4s" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 32882C4CEEA; Mon, 23 Jun 2025 21:49:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1750715376; bh=SNxeY0zZV+xuqFmn+RUUDNa4Go7YcxSAQH7yOlBmGmw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eJjKA+4stWEnaPtAM0G7E9fguFb+3uhOz6VrooGOnYuccq29G6P+VPDvUEqdw+dOF RUOnJ9bIOYVGIbLOa30N4x33Pmitfj3oJy82vVPKHUtmRG614nfI5ly/K60xpoEamV BMG2tOD6SO7cHo57fElD6sxpFnKC26NaNNTw862o= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Daniel Wagner , Justin Tee , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 5.10 271/355] scsi: lpfc: Use memcpy() for BIOS version Date: Mon, 23 Jun 2025 15:07:52 +0200 Message-ID: <20250623130634.922385646@linuxfoundation.org> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250623130626.716971725@linuxfoundation.org> References: <20250623130626.716971725@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Daniel Wagner [ Upstream commit ae82eaf4aeea060bb736c3e20c0568b67c701d7d ] The strlcat() with FORTIFY support is triggering a panic because it thinks the target buffer will overflow although the correct target buffer size is passed in. Anyway, instead of memset() with 0 followed by a strlcat(), just use memcpy() and ensure that the resulting buffer is NULL terminated. BIOSVersion is only used for the lpfc_printf_log() which expects a properly terminated string. Signed-off-by: Daniel Wagner Link: https://lore.kernel.org/r/20250409-fix-lpfc-bios-str-v1-1-05dac9e51e13@kernel.org Reviewed-by: Justin Tee Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/lpfc/lpfc_sli.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c index 84f90f4d5abd8..ff39c596f0007 100644 --- a/drivers/scsi/lpfc/lpfc_sli.c +++ b/drivers/scsi/lpfc/lpfc_sli.c @@ -5530,9 +5530,9 @@ lpfc_sli4_get_ctl_attr(struct lpfc_hba *phba) phba->sli4_hba.lnk_info.lnk_no = bf_get(lpfc_cntl_attr_lnk_numb, cntl_attr); - memset(phba->BIOSVersion, 0, sizeof(phba->BIOSVersion)); - strlcat(phba->BIOSVersion, (char *)cntl_attr->bios_ver_str, + memcpy(phba->BIOSVersion, cntl_attr->bios_ver_str, sizeof(phba->BIOSVersion)); + phba->BIOSVersion[sizeof(phba->BIOSVersion) - 1] = '\0'; lpfc_printf_log(phba, KERN_INFO, LOG_SLI, "3086 lnk_type:%d, lnk_numb:%d, bios_ver:%s\n", -- 2.39.5