From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE83A223714; Mon, 23 Jun 2025 21:53:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750715584; cv=none; b=qUcXaHlIPsM+WMh0nm6j45uHQS/E2wfuSZxfM65k/U5X35Tv304UfNlqUtsCom6KwqcgDjSDbduoGIZ90epU18kiA7I5phIn8DgShckWe+hAJlizeBNKhlPDwKXvwoFzBjqCIW1SyHkPs5ET6YnLgoP9n+/forIS8eQbh5CnJGA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750715584; c=relaxed/simple; bh=yib6hzuxCZG3eHD/W5GXUIPzvp/p6iV179gOCVTCins=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uh0B5T3dVjtjCvFrl7xMATGY88GXA2QxHkHUJmpfe26f4z3M4b5BIeet2L4flGvx/WAfQ9MTYsNb/kF2PDtzxkJUM+THQ3ICMc2i6W+TfwtU1ASIjhJkkBQ0nxOpulJLGkVldm/uD8HVYRj4WNTlTpy6STtdqPsGWfvpx+MQEEc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=n1akRHTP; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="n1akRHTP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 46EECC4CEF2; Mon, 23 Jun 2025 21:53:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1750715584; bh=yib6hzuxCZG3eHD/W5GXUIPzvp/p6iV179gOCVTCins=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=n1akRHTPMz4hzXj7JjMzv7UeyHlskfK25EDm7E+h5T4zSPPqv6+8HkqpP/MO5fqWR MdaaZ/3d+SJN24C5Cu35Fi9RnmpNajuu5zD2uhFrQWK5CxpiHuwLAkgUfPWwBFzcZT Z1aPGy1j5ICyHcDbqKq1iJ4jdryQBX8sG/9SXavw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, maher azz , Matt Porter , Alexandre Bounine , Linus Torvalds , Andrew Morton Subject: [PATCH 5.10 284/355] drivers/rapidio/rio_cm.c: prevent possible heap overwrite Date: Mon, 23 Jun 2025 15:08:05 +0200 Message-ID: <20250623130635.317741082@linuxfoundation.org> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250623130626.716971725@linuxfoundation.org> References: <20250623130626.716971725@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Andrew Morton commit 50695153d7ddde3b1696dbf0085be0033bf3ddb3 upstream. In riocm_cdev_ioctl(RIO_CM_CHAN_SEND) -> cm_chan_msg_send() -> riocm_ch_send() cm_chan_msg_send() checks that userspace didn't send too much data but riocm_ch_send() failed to check that userspace sent sufficient data. The result is that riocm_ch_send() can write to fields in the rio_ch_chan_hdr which were outside the bounds of the space which cm_chan_msg_send() allocated. Address this by teaching riocm_ch_send() to check that the entire rio_ch_chan_hdr was copied in from userspace. Reported-by: maher azz Cc: Matt Porter Cc: Alexandre Bounine Cc: Linus Torvalds Cc: Signed-off-by: Andrew Morton Signed-off-by: Greg Kroah-Hartman --- drivers/rapidio/rio_cm.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/rapidio/rio_cm.c +++ b/drivers/rapidio/rio_cm.c @@ -787,6 +787,9 @@ static int riocm_ch_send(u16 ch_id, void if (buf == NULL || ch_id == 0 || len == 0 || len > RIO_MAX_MSG_SIZE) return -EINVAL; + if (len < sizeof(struct rio_ch_chan_hdr)) + return -EINVAL; /* insufficient data from user */ + ch = riocm_get_channel(ch_id); if (!ch) { riocm_error("%s(%d) ch_%d not found", current->comm,