From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DCE3223DD0; Mon, 23 Jun 2025 21:55:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750715732; cv=none; b=PbclVBsF+LofT98sGgFNA51BWSjdHcVCICbRHpfpQ5rlZq5dFhEIoEPG+5tsw5ihN6cjpTdmzaIkml0WWDNvt7xfSg5mwDO1VgCUY2Afpb6NRTOiey1bnqFO7OF9cvbQP9I4351srLKnX1BAOLWE4aeHDTFU/NJ66NabFih9Otg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750715732; c=relaxed/simple; bh=yE4n12fgpu23GFbEv8Sgg+yc6rdJ8ZTOjTKfnKj0ItA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EE6OXXen6miJeAVxmMXxoXtnwsXrija5TfrKvfWrmeaI8QsebSIq8X+BbspQj8SFmj+b0bSPnpocp6el4FaZuIB7NM0v9C6re5ER8mR1TTKzuI4IRTK5R4UoWtnmyLvv2H40OlE7YwG2np8QxEgxgQf9KNxr9OKRdeDNfs4pYts= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=G3CRJDU3; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="G3CRJDU3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 69E02C4CEEA; Mon, 23 Jun 2025 21:55:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1750715731; bh=yE4n12fgpu23GFbEv8Sgg+yc6rdJ8ZTOjTKfnKj0ItA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=G3CRJDU3BHGEmUbF3QhuW23EU/ZJBPvFGuWylSh4ot3I3KYeI+mRx+sru0f7p6k6n ai9I3IpDJJaeNRbsKqjJy5IfIvMo51GCZVY1nuI4thsjR3HJOix2jzGaHVbrTHnYBa 7xZLY4FZRkx9lG0hnUlONsLHAgfVZtxYus5VhGbE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, WangYuli , Dmitry Torokhov Subject: [PATCH 5.10 293/355] Input: sparcspkr - avoid unannotated fall-through Date: Mon, 23 Jun 2025 15:08:14 +0200 Message-ID: <20250623130635.584698528@linuxfoundation.org> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250623130626.716971725@linuxfoundation.org> References: <20250623130626.716971725@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: WangYuli commit 8b1d858cbd4e1800e9336404ba7892b5a721230d upstream. Fix follow warnings with clang-21i (and reformat for clarity): drivers/input/misc/sparcspkr.c:78:3: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough] 78 | case SND_TONE: break; | ^ drivers/input/misc/sparcspkr.c:78:3: note: insert 'break;' to avoid fall-through 78 | case SND_TONE: break; | ^ | break; drivers/input/misc/sparcspkr.c:113:3: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough] 113 | case SND_TONE: break; | ^ drivers/input/misc/sparcspkr.c:113:3: note: insert 'break;' to avoid fall-through 113 | case SND_TONE: break; | ^ | break; 2 warnings generated. Signed-off-by: WangYuli Link: https://lore.kernel.org/r/6730E40353C76908+20250415052439.155051-1-wangyuli@uniontech.com Signed-off-by: Dmitry Torokhov Signed-off-by: Greg Kroah-Hartman --- drivers/input/misc/sparcspkr.c | 22 ++++++++++++++++------ 1 file changed, 16 insertions(+), 6 deletions(-) --- a/drivers/input/misc/sparcspkr.c +++ b/drivers/input/misc/sparcspkr.c @@ -74,9 +74,14 @@ static int bbc_spkr_event(struct input_d return -1; switch (code) { - case SND_BELL: if (value) value = 1000; - case SND_TONE: break; - default: return -1; + case SND_BELL: + if (value) + value = 1000; + break; + case SND_TONE: + break; + default: + return -1; } if (value > 20 && value < 32767) @@ -112,9 +117,14 @@ static int grover_spkr_event(struct inpu return -1; switch (code) { - case SND_BELL: if (value) value = 1000; - case SND_TONE: break; - default: return -1; + case SND_BELL: + if (value) + value = 1000; + break; + case SND_TONE: + break; + default: + return -1; } if (value > 20 && value < 32767)