From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8626A3FB1B; Mon, 23 Jun 2025 22:03:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750716198; cv=none; b=YoziW9gQ6H3sLIY8BPY5ag6i4OTgHHmc03jNPujkj2o07e36n2DONPA/wvXYpZwvBVrnCHHZPOSORHZwK7VaB0EYfUA/gkvoRZfQHBTN8xmKEDU9+2LI+tAlRMESoU4uAimhpN41OPHEGqAY7GaTY+P6cNkzwIhA5+WLLTygQ1Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750716198; c=relaxed/simple; bh=lA6n5MB+IAjSaC+XOvscROuOwovHHiUnd/lporEQeww=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Y9j8nypgQi6k9bwg0ItpsqBi9rOtqU7zUz5rPWs0SsAqaQdSCP2icDrs3Vubvt3PUWLP4H67F2e0eF8Uos7XiUAV0t3fq662KRXo2w65BJHMaauB0ZrYQPFbUS1P/jac/NhaGREXfYuefhfbBAptpWBPU36UR/h5DvkRTcFCXF0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=pfsBuEaX; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="pfsBuEaX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1CD42C4CEEA; Mon, 23 Jun 2025 22:03:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1750716198; bh=lA6n5MB+IAjSaC+XOvscROuOwovHHiUnd/lporEQeww=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pfsBuEaX7GAZuFPh5mgbvPDGCRnkbE9aT5KaeWN5/vYO69J4duUjzR1UWfEWEane1 voU+Ncyj0XZUKQhSyf8y1FhX4aEb/oK8H+DXyjHQYMfjcw/+MWwrgJU98br7Yj+6A8 MUCxBs+EJEcyhm9zLVt6y197PcGTc8I6M4DFoakY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Baisheng Gao , Mark Rutland , "Peter Zijlstra (Intel)" , Sasha Levin Subject: [PATCH 5.10 354/355] perf: Fix sample vs do_exit() Date: Mon, 23 Jun 2025 15:09:15 +0200 Message-ID: <20250623130637.359641556@linuxfoundation.org> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250623130626.716971725@linuxfoundation.org> References: <20250623130626.716971725@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Peter Zijlstra [ Upstream commit 4f6fc782128355931527cefe3eb45338abd8ab39 ] Baisheng Gao reported an ARM64 crash, which Mark decoded as being a synchronous external abort -- most likely due to trying to access MMIO in bad ways. The crash further shows perf trying to do a user stack sample while in exit_mmap()'s tlb_finish_mmu() -- i.e. while tearing down the address space it is trying to access. It turns out that we stop perf after we tear down the userspace mm; a receipie for disaster, since perf likes to access userspace for various reasons. Flip this order by moving up where we stop perf in do_exit(). Additionally, harden PERF_SAMPLE_CALLCHAIN and PERF_SAMPLE_STACK_USER to abort when the current task does not have an mm (exit_mm() makes sure to set current->mm = NULL; before commencing with the actual teardown). Such that CPU wide events don't trip on this same problem. Fixes: c5ebcedb566e ("perf: Add ability to attach user stack dump to sample") Reported-by: Baisheng Gao Suggested-by: Mark Rutland Signed-off-by: Peter Zijlstra (Intel) Link: https://lkml.kernel.org/r/20250605110815.GQ39944@noisy.programming.kicks-ass.net Signed-off-by: Sasha Levin --- kernel/events/core.c | 7 +++++++ kernel/exit.c | 17 +++++++++-------- 2 files changed, 16 insertions(+), 8 deletions(-) diff --git a/kernel/events/core.c b/kernel/events/core.c index 21f56dd6c05a3..b133abe23a4b1 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -6628,6 +6628,10 @@ perf_sample_ustack_size(u16 stack_size, u16 header_size, if (!regs) return 0; + /* No mm, no stack, no dump. */ + if (!current->mm) + return 0; + /* * Check if we fit in with the requested stack size into the: * - TASK_SIZE @@ -7228,6 +7232,9 @@ perf_callchain(struct perf_event *event, struct pt_regs *regs) const u32 max_stack = event->attr.sample_max_stack; struct perf_callchain_entry *callchain; + if (!current->mm) + user = false; + if (!kernel && !user) return &__empty_callchain; diff --git a/kernel/exit.c b/kernel/exit.c index af9c8e794e4d7..cfdf2d275bba8 100644 --- a/kernel/exit.c +++ b/kernel/exit.c @@ -844,6 +844,15 @@ void __noreturn do_exit(long code) tsk->exit_code = code; taskstats_exit(tsk, group_dead); + /* + * Since sampling can touch ->mm, make sure to stop everything before we + * tear it down. + * + * Also flushes inherited counters to the parent - before the parent + * gets woken up by child-exit notifications. + */ + perf_event_exit_task(tsk); + exit_mm(); if (group_dead) @@ -860,14 +869,6 @@ void __noreturn do_exit(long code) exit_task_work(tsk); exit_thread(tsk); - /* - * Flush inherited counters to the parent - before the parent - * gets woken up by child-exit notifications. - * - * because of cgroup mode, must be called before cgroup_exit() - */ - perf_event_exit_task(tsk); - sched_autogroup_exit_task(tsk); cgroup_exit(tsk); -- 2.39.5