From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED2F93FB1B; Mon, 23 Jun 2025 21:55:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750715749; cv=none; b=E41NbctZbm05cBKuN1yM6jfr1nrxBD7lzGROQcLAxR5QMJWdzMOJTI06Uelf+v9SWNxRuokmJCq6L1WQupLgcWtua6WN60JiZ/DgRPFC6mCXazLHrS+LRGM2IXtsbAfhJfuQ3kmIH03OCMlib1I9S2IjJYpecHubf+PwomEZQ/4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750715749; c=relaxed/simple; bh=YSrzVT/8J4m6/QzMZ0TstMFWd+a88tVfGc90Oi98h2E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PDY72hWIBqkP6oir43swsY+OpnEMHab8iDpQLAdB9g3wWior84Y9ZjzZbmuzDG/YVApGs+6xqAmIv6j8vCUeZeEUySGW/qopqMsAkLoPsfg6+NWl29lZ/eK+5djOQZSviRXsGHhRg5rQ97kH7xM4kqitkTup5iIEznyChZVaRg0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=m7N8oQ/K; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="m7N8oQ/K" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7A3D9C4CEEA; Mon, 23 Jun 2025 21:55:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1750715748; bh=YSrzVT/8J4m6/QzMZ0TstMFWd+a88tVfGc90Oi98h2E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=m7N8oQ/KfxfA/+z9u3PQFUY8STCh/NKNlesWas2PwfkthcJ5IZ2SPW3vqM0Et9j1B oK1vLmwW0U1jjIzw1N9hraNV6Ep1CGR4fFUHeac6XwN6V82Mgz7VwPkZ4iZWgzLqEs 2/pDC7eNFa4YU+A58Z/kXriMbSIKBL7AUImrJhLs= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ayushi Makhija , Dmitry Baryshkov , Dmitry Baryshkov , Sasha Levin Subject: [PATCH 5.15 276/411] drm/bridge: anx7625: change the gpiod_set_value API Date: Mon, 23 Jun 2025 15:07:00 +0200 Message-ID: <20250623130640.600231171@linuxfoundation.org> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250623130632.993849527@linuxfoundation.org> References: <20250623130632.993849527@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ayushi Makhija [ Upstream commit 50935044e58e563cdcfd556d62f27bc8744dd64e ] Use gpiod_set_value_cansleep() instead of gpiod_set_value() to fix the below call trace in the boot log: [ 5.690534] Call trace: [ 5.690536] gpiod_set_value+0x40/0xa4 [ 5.690540] anx7625_runtime_pm_resume+0xa0/0x324 [anx7625] [ 5.690545] __rpm_callback+0x48/0x1d8 [ 5.690549] rpm_callback+0x6c/0x78 Certain GPIO controllers require access via message-based buses such as I2C or SPI, which may cause the GPIOs to enter a sleep state. Therefore, use the gpiod_set_value_cansleep(). Signed-off-by: Ayushi Makhija Reviewed-by: Dmitry Baryshkov Link: https://lore.kernel.org/r/20250505094245.2660750-7-quic_amakhija@quicinc.com Signed-off-by: Dmitry Baryshkov Signed-off-by: Sasha Levin --- drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c index 01612d2c034af..257f69b5e1783 100644 --- a/drivers/gpu/drm/bridge/analogix/anx7625.c +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c @@ -920,10 +920,10 @@ static void anx7625_power_on(struct anx7625_data *ctx) usleep_range(11000, 12000); /* Power on pin enable */ - gpiod_set_value(ctx->pdata.gpio_p_on, 1); + gpiod_set_value_cansleep(ctx->pdata.gpio_p_on, 1); usleep_range(10000, 11000); /* Power reset pin enable */ - gpiod_set_value(ctx->pdata.gpio_reset, 1); + gpiod_set_value_cansleep(ctx->pdata.gpio_reset, 1); usleep_range(10000, 11000); DRM_DEV_DEBUG_DRIVER(dev, "power on !\n"); @@ -943,9 +943,9 @@ static void anx7625_power_standby(struct anx7625_data *ctx) return; } - gpiod_set_value(ctx->pdata.gpio_reset, 0); + gpiod_set_value_cansleep(ctx->pdata.gpio_reset, 0); usleep_range(1000, 1100); - gpiod_set_value(ctx->pdata.gpio_p_on, 0); + gpiod_set_value_cansleep(ctx->pdata.gpio_p_on, 0); usleep_range(1000, 1100); ret = regulator_bulk_disable(ARRAY_SIZE(ctx->pdata.supplies), -- 2.39.5