From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 894764409; Mon, 23 Jun 2025 22:00:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750716046; cv=none; b=aPz25nqW6ItmKVzHE1/2BbLMT4F41hYQnhtm9GubBbS5OdMLSGbaZzxgvFvrScwERj6F+3OJe67pks98AW/fargQd6/2/ZpMn/WjUaU5gp580ITFPLRthAW521jCLO1ezTVuATPrKHMYQG8Z8RPqSajnjpj1QBbPK1ty83u/4gg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750716046; c=relaxed/simple; bh=jj8C/qwPkrZ0T/AkKAtXIK8XIf+SODzCr90mIS/lGNk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HE0Msj9mpj4pA5BD6fzUAsuGqKTvdjM8FH8e8Q7F8n1600FRqKpiKFGu1XyDNkZxNqsItDyR6KgEw3AaMrSxEV/3npAE1Nx2Q+peZ/m9YhMov9D24HLfZ8kknCZh6iGOMY6PqNAbNCkTkCnIuTRWXoRQvtosZy153o5lbfQpjvw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=NXC9lKFR; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="NXC9lKFR" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2010AC4CEEA; Mon, 23 Jun 2025 22:00:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1750716046; bh=jj8C/qwPkrZ0T/AkKAtXIK8XIf+SODzCr90mIS/lGNk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NXC9lKFRkB6Wcs8ZLg3ramX+GQEjFFnri/d+TS5/+/taZ+y8dP4QZ93+A34kNFArq tb2m40HOCkjIpdbt3gn3sxQetTraqDTzHbKs2m5YW70o0tapnt3q3L6zXaH2etlzxy SpHyjSp74CPIEFE1gge4yyyTWiwV0nkRZqtCLd2w= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Wentao Liang , Hans Verkuil , Sasha Levin Subject: [PATCH 5.15 299/411] media: platform: exynos4-is: Add hardware sync wait to fimc_is_hw_change_mode() Date: Mon, 23 Jun 2025 15:07:23 +0200 Message-ID: <20250623130641.174307236@linuxfoundation.org> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250623130632.993849527@linuxfoundation.org> References: <20250623130632.993849527@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Wentao Liang [ Upstream commit bd9f6ce7d512fa21249415c16af801a4ed5d97b6 ] In fimc_is_hw_change_mode(), the function changes camera modes without waiting for hardware completion, risking corrupted data or system hangs if subsequent operations proceed before the hardware is ready. Add fimc_is_hw_wait_intmsr0_intmsd0() after mode configuration, ensuring hardware state synchronization and stable interrupt handling. Signed-off-by: Wentao Liang Signed-off-by: Hans Verkuil Signed-off-by: Sasha Levin --- drivers/media/platform/exynos4-is/fimc-is-regs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/exynos4-is/fimc-is-regs.c b/drivers/media/platform/exynos4-is/fimc-is-regs.c index 366e6393817d2..5f9c44e825a5f 100644 --- a/drivers/media/platform/exynos4-is/fimc-is-regs.c +++ b/drivers/media/platform/exynos4-is/fimc-is-regs.c @@ -164,6 +164,7 @@ int fimc_is_hw_change_mode(struct fimc_is *is) if (WARN_ON(is->config_index >= ARRAY_SIZE(cmd))) return -EINVAL; + fimc_is_hw_wait_intmsr0_intmsd0(is); mcuctl_write(cmd[is->config_index], is, MCUCTL_REG_ISSR(0)); mcuctl_write(is->sensor_index, is, MCUCTL_REG_ISSR(1)); mcuctl_write(is->setfile.sub_index, is, MCUCTL_REG_ISSR(2)); -- 2.39.5